Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-plugins): display activation banner immediately upon activation refresh #3153

Closed
DevinWalker opened this issue May 2, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@DevinWalker
Copy link
Member

commented May 2, 2018

User Story

As a admin, I want when I activate an addon that I see the activation banner immediately so that I can quickly access settings. Right now it's not displaying until I manually refresh the plugin listing page.

Acceptance Criteria

  • As an admin I can activate the plugin and

Visuals

See video: https://goo.gl/eevv6v

@raftaar1191

This comment has been minimized.

Copy link
Member

commented May 4, 2018

Finding

When activating the Give Add-on one by one it does not show me the message activation banner for both in fact it hides the last one and show the latest add-on notices which are been activated

Video link: https://screencast-o-matic.com/watch/cFhf0sbZIn

Example: In Give Core 2.0 it used to show Activation banner for all the add-on
image

Expected in Give Core 2.1.2
image

@raftaar1191 raftaar1191 reopened this May 4, 2018

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented May 5, 2018

Yeah that's intentional @raftaar1191 - no need to reopen.

@DevinWalker DevinWalker closed this May 5, 2018

@raftaar1191

This comment has been minimized.

Copy link
Member

commented May 5, 2018

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented May 5, 2018

Reopening pending ongoing review after speaking with @raftaar1191

@DevinWalker DevinWalker reopened this May 5, 2018

@ravinderk ravinderk assigned raftaar1191 and unassigned emgk May 8, 2018

DevinWalker added a commit that referenced this issue May 8, 2018

Merge pull request #3194 from raftaar1191/issue-3153
fix(admin-plugins): display activation banner immediately upon activation refresh #3153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.