Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(currency-switcher): amount should be formatted based on the currency I switched into. #3203

Closed
emgk opened this issue May 10, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@emgk
Copy link
Member

commented May 10, 2018

User Story

As a Developer, I want to use the form's currency format setting to format the various amount inside the verify min/max amount and when displaying the amount in the price level element so that I can see the correct donation amount in the currency I have switched into.

NOTE: Related to currency-switcher.

Current Behavior

  1. When verifying the min/max amount it is sanitizing the amount based on the Give's base currency.
  2. If the currency is auto-switched to another preferred currency then the amount is appearing in Give's base currency format.

Expected Behavior

  1. min/max amount should be sanitized from the switched currency.
  2. If the currency is auto-switched to another currency then, the variable amount should appear in that switched currency.

Related

Tasks

  • Pass the currency when displaying the variable amount.
  • Add new filter to the verify min/max amount to re-verify the amount through any add-on.
@mehul0810

This comment has been minimized.

Copy link
Contributor

commented May 17, 2018

I'm facing a minimum amount for this form issue as shown in the screenshot. So, reopening this issue.
image

@emgk

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

The logic of verifying the min/max amount isn't correct. re-opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.