Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(donation-form): use form's currency in the process of the donation creations. #3401

Closed
emgk opened this issue Jun 25, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@emgk
Copy link
Member

commented Jun 25, 2018

User Story

As a Developer, I want to change the form's currency using the give_currency and that decided currency should be used to format/unformat the currency whenever the donation creation process is happening so that donation's amount will be correctly imported inside the database.

Current Behavior

When I change the curency using give_currency filter for specific donation form, the saniting function are not unformatting the amount came from the donation form.

Expected Behavior

I expect to use the form's currency in whole process of donation creation, so that format/unformat can be done properly.

Possible Solution

Pass form's currency when sanitizing the amount in the process of the donation creation.
use: give_get_currency( $form_id ) to get the form's currency.

Steps to Reproduce

  1. Change the currency using the 'give_currency' filter for specific donation form and make donation you'll see that the donation amount is not formatted properly as per the currency formatting setting.

Related

Tasks

  • Anlysis the donation creation process and pass the give_get_currency($form_id) to get the form's currency always.
  • Test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.