Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify language of dry run messages #3699

Closed
Benunc opened this issue Sep 19, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Benunc
Copy link
Member

commented Sep 19, 2018

Current Behavior

Currently, the language on the importer is very broken:

screen shot 2018-09-18 at 3 17 24 pm

Expected Behavior

In the screenshot above, I expect the language to read
1 donor will be created
7 donations will be imported
6 duplicate donors detected

Steps to Reproduce

  1. Import a CSV, and select "dry run"
  2. This is the output.

Possible Solution

Since it's primarily dry run functionality that is making confusing language, switch to modal tense would have on processes that did not run (like imports and creation) and simple past tense for the "detected" ones.

Acceptance Criteria

  • The language is clear for dry run imports
@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Sep 19, 2018

@Benunc Since these messages appear directly above the Start Import button, I have adjusted the strings to future tense so they describe what will happen when the import is started.

@Sidsector9 Please move forward with the string replacements above and ping me for review on this one.

@kevinwhoffman kevinwhoffman changed the title fix: clean up language on the importer for dry runs Clarify language of Dry Run messages Sep 19, 2018

ravinderk added a commit that referenced this issue Sep 20, 2018

Merge pull request #3703 from WordImpress/issue/3699
fix: Clarify language of Dry Run messages #3699

@DevinWalker DevinWalker changed the title Clarify language of Dry Run messages fix: clarify language of dry run messages Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.