Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not display shortcode generator above form content #3739

Closed
Benunc opened this issue Oct 9, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@Benunc
Copy link
Member

commented Oct 9, 2018

Bug Report

User Story

As a user, I want to only see the Give shortcode generator on editors where using it won't break things.

Current Behavior

Currently, the shortcode generator button shows up on the Form Content editor.

Expected Behavior

Since using a shortcode within a form is never a good idea, I would not expect it to be there.

Bug Type

  • This bug describes functionality that once worked as expected in version ?.?.?.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Install Give at example.com
  2. Navigate to example.com/wp-admin/post-new.php?post_type=give_forms&give_tab=form_content_options
  3. enable the form content section
  4. See the shortcode builder button.

Visuals

screen shot 2018-10-09 at 7 40 22 am

Possible Solution

https://github.com/impress-org/give/blob/release/2.3.0/includes/admin/shortcodes/class-shortcode-button.php#L234

Need to exclude the Give Form itself from the list somehow.

Related

cd544dd
https://secure.helpscout.net/conversation/672322591/26332/?

Acceptance Criteria

  • the Give shortcode generator does not show up on the form content editor
  • the shortcode button still shows up on the normal editor for posts and pages

Environment

WordPress System Info ### WordPress Environment ###

Home URL: http://excited-otter.w6.poopy.life
Site URL: http://excited-otter.w6.poopy.life
WP Version: 4.9.8
WP Multisite: –
WP Memory Limit: 512 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: d5.internal.wpsandbox.io, SRV: excited-otter.w6.poopy.life
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.26 (Red Hat)
PHP Version: 5.6.37
PHP Post Max Size: 256 MB
PHP Time Limit: 600
PHP Max Input Vars: 3000
PHP Max Upload Size: 256 MB
cURL Version: 7.60.0, OpenSSL/1.0.2k
SUHOSIN Installed: –
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: Your server does not have the SoapClient class enabled - some gateway plugins which use SOAP may not work as expected.
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.2.5
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://excited-otter.w6.poopy.life/donation-confirmation/
Failure Page: http://excited-otter.w6.poopy.life/donation-failed/
Donation History Page: http://excited-otter.w6.poopy.life/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Active Give Add-ons

Other Active Plugins

Sandbox: by Soflyy – 1.1.3

Inactive Plugins

Theme

Name: Twenty Seventeen
Version: 1.5
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

@kevinwhoffman kevinwhoffman changed the title fix: remove shortcode generator from the form content section. fix: do not display shortcode generator above form content Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.