Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load donor wall gravatars after page load #3758

Closed
ravinderk opened this issue Oct 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ravinderk
Copy link
Collaborator

commented Oct 12, 2018

Feature Request

User Story

As a site owner, I want to donor wall shortcode but this shortcode has performance issue because it loads donor gravatar before the page load.

To improve performance we can load gravatar after page load if shortcode attribute avatar set to true.

Ref: for more information read Suggestion section in Pr description: #3752

Acceptance Criteria

  • Output donor name initials by default.
  • Use data attribute to store avatar shortcode attribute value.
  • If avatar set to true load gravatar with https://www.npmjs.com/package/gravatar-api js library.

@kevinwhoffman kevinwhoffman changed the title feat: loading gravatar after page load in donor wall shortcode feat: load donor wall gravatars after page load Oct 12, 2018

@nishitlangaliya

This comment has been minimized.

Copy link
Member

commented Oct 15, 2018

Slack Call Summary

Participants: @ravinderk , @nishitlangaliya
Topic: Discussion on how to load donor wall gravatars after page load
Result: I had a confusion how to proceed with load gravatars after page load. @ravinderk guide me to proceed and as per suggestion, I am moving forward with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.