New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by minimum amount #1253

Closed
ravinderk opened this Issue Nov 17, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@ravinderk
Collaborator

ravinderk commented Nov 17, 2016

Issue Overview

Currently, we are sorting form list in wp-backend on basis of price which internally sorts form list on basis of _give_set_price. We will not get correct order if we also have some multi-level donation form
screen shot 2016-11-17 at 10 59 39 am

Possible Solution

We can sort forms list on basis of _give_set_price ( in case of simple form) and minimum amount level ( in case of multi donation form).

Steps to Reproduce (for bugs)

  1. Go to Donations --> All Forms
  2. Sort list by Amount

@DevinWalker DevinWalker added this to the 2.0 milestone Nov 17, 2016

@DevinWalker DevinWalker added the bug label Nov 17, 2016

@DevinWalker DevinWalker changed the title from Sorting by minimum amount to Sorting by minimum amount Nov 17, 2016

@DevinWalker DevinWalker added ready and removed ready labels Nov 17, 2016

@DevinWalker DevinWalker modified the milestones: 1.8.9, 2.0 May 26, 2017

@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman May 30, 2017

Member

Sorting this column is problematic for a couple of reasons:

  1. It's difficult to sort a multi-level range as a single field. When sorting a range of values such as $5-$15, the upper limit is not being considered when sorting in reverse. Instead the value of the field is considered to be $5 (the lower limit) at all times.
  2. Custom amounts add confusion. A form may have multi-level donations set at $5-15 but it also accepts custom amounts as low as $3. This means the actual range of acceptable amounts is $3-Infinity since there is no maximum limit set for the custom amount. Indicating the amount as $5-15 when the actual acceptable amount is $3-Infinity is misleading.
Member

kevinwhoffman commented May 30, 2017

Sorting this column is problematic for a couple of reasons:

  1. It's difficult to sort a multi-level range as a single field. When sorting a range of values such as $5-$15, the upper limit is not being considered when sorting in reverse. Instead the value of the field is considered to be $5 (the lower limit) at all times.
  2. Custom amounts add confusion. A form may have multi-level donations set at $5-15 but it also accepts custom amounts as low as $3. This means the actual range of acceptable amounts is $3-Infinity since there is no maximum limit set for the custom amount. Indicating the amount as $5-15 when the actual acceptable amount is $3-Infinity is misleading.
@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker May 30, 2017

Member

The issue right now the column is sortable, but it doesn't sort in order. As a user, I just want it to sort more logically or not sort at all.

  1. It's still an improvement if we only sort by the minimum donation amount. You can easily scan the column and see the donation amounts line up logically since they are sorting by minimum each time. We can start here an iterate from this point as needed.
  2. Disregard custom amounts. Perhaps we can have an custom amount indicator within the column, but I don't think the column data needs to change from $5 -15 to $3-infinity when custom amounts are accepted. That would likely confuse users who didn't know it was custom amount enabled.
Member

DevinWalker commented May 30, 2017

The issue right now the column is sortable, but it doesn't sort in order. As a user, I just want it to sort more logically or not sort at all.

  1. It's still an improvement if we only sort by the minimum donation amount. You can easily scan the column and see the donation amounts line up logically since they are sorting by minimum each time. We can start here an iterate from this point as needed.
  2. Disregard custom amounts. Perhaps we can have an custom amount indicator within the column, but I don't think the column data needs to change from $5 -15 to $3-infinity when custom amounts are accepted. That would likely confuse users who didn't know it was custom amount enabled.
@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman May 30, 2017

Member

I agree the best path forward is to sort by minimum donation amount while disregarding custom amounts. This means we're really sorting by the minimum set donation.

The issue is that we don't currently have a meta field that could be considered the minimum set donation for both single- and multi-level forms. One possibility that @mehul0810 suggested in Slack was to set _give_set_price equal to the lowest donation level for multi-level forms. Doing so would give us a single meta field that could be sorted in a straightforward manner.

Member

kevinwhoffman commented May 30, 2017

I agree the best path forward is to sort by minimum donation amount while disregarding custom amounts. This means we're really sorting by the minimum set donation.

The issue is that we don't currently have a meta field that could be considered the minimum set donation for both single- and multi-level forms. One possibility that @mehul0810 suggested in Slack was to set _give_set_price equal to the lowest donation level for multi-level forms. Doing so would give us a single meta field that could be sorted in a straightforward manner.

@mehul0810 mehul0810 referenced this issue Jun 1, 2017

Merged

Issue/1253 #1752

1 of 3 tasks complete

@ravinderk ravinderk added the has pr label Jun 1, 2017

@DevinWalker DevinWalker closed this Jun 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment