Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Modal close button gets hidden with some themes #1709
Some themes come with magnific pre-installed and they do all kinds of crazy things with it. Generally, Give handles that fine, with the exception of the CLOSE button. We need to tighen up the styles on it to prevent it from getting lost.
The close button should always be visible in the top-right of the Give modal window.
Sometimes it gets bumped off the screen and is invisible which makes it virtually impossible for common users/donors to close it if they want.
Since our button is physically inside our Give form, we can target it very specifically:
We currently have some custom Give styles for the close button, but I don't think they have enough specificity:
Updating those as follows should resolve it.
Steps to Reproduce (for bugs)
I have a theme called "Impreza" which displays this behavior, and the above styles resolved it. And here's a customer which had the same issue with a different theme:
We received another ticket with this issue here: https://secure.helpscout.net/conversation/457276120/11260?folderId=1457790