Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add advanced filters for Donors screen #1882

Closed
DevinWalker opened this issue Jul 18, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@DevinWalker
Copy link
Member

commented Jul 18, 2017

User Story

As a Give admin, I want more control over my list of donors so that I can learn more about

Possible Solution

Currently the filters for the donations aren't very feature rich. I propose we add more filters to the donations listing screen:

  1. Search by Donor Name
  2. Filter by Date (currently enabled)
  3. Filter by Donation Form (currently possible through search but not very intuitive)

Visuals

The location of the proposed filters:

2018-01-31_17-46-31

Mockup of the Donor filters based on the same control bar that is present on the Donations screen:

image

Related

#1199

Acceptance Criteria

  • The old donor search bar has been removed.
  • When a string is entered into search, only donors whose names contain that string are displayed.
  • When start and end dates are provided, only donors created between those dates are displayed.
  • When only a start date is provided, it shows all donors created after that date.
  • When only an end date is provided, it shows all donors created before that date.
  • When a form is selected, only donors who have donated to that form are displayed.
  • When more than one control is manipulated, the filters have a stacking effect. e.g. You can search for donors with the last name "Smith" created between January and February who donated to a specific form.
  • The Donation date filters work with a non-default date format in WP settings.
  • The Donor date filters work with a non-default date format in WP settings.
  • The search placeholder reads: Name, Email, or Donation ID (adjust input width if necessary so text is not cut off)
  • Searching for a Donation ID yields results for donations created with and without sequential ordering enabled.
  • The search controls work with filters such as Completed and Subscriptions that appear above the list table.
  • Each field label is aligned vertically with its respective input.

@DevinWalker DevinWalker added this to the 2.1 milestone Jul 18, 2017

@DevinWalker DevinWalker self-assigned this Feb 1, 2018

@DevinWalker DevinWalker changed the title Add advanced filters for donations Add advanced filters for donors list screen Feb 1, 2018

@DevinWalker DevinWalker removed this from the 2.1 milestone Mar 6, 2018

@DevinWalker DevinWalker removed their assignment Mar 12, 2018

@kevinwhoffman kevinwhoffman changed the title Add advanced filters for donors list screen feat: add advanced filters for Donors screen Oct 24, 2018

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

@nishitlangaliya We should be able to make use of the same control bar UI from the Donations screen for the Donors screen. See the visuals provided above.

I have also updated the acceptance criteria to describe the intended behavior based on the control bar.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

Slack Call Summary

Participants: @nishitlangaliya @kevinwhoffman
Topic: Review design and acceptance criteria for donor filters
Result: Nishit has a clear understanding of the acceptance criteria. We are borrowing the design of the existing filters from the Donations screen. We have also clarified acceptance criteria regarding what should happen if only one start or end date is provided.

@nishitlangaliya

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Slack Call Summary

Participants: @nishitlangaliya @ravinderk
Topic: Discussion regarding search input box search criteria.
Result: Currently, Search input was working base on tag like Name: or Note: so I had a confusion on that how we need to keep. So in that as per suggesion we will keep tag specific search also
by default it will search on name. and also check if the search is email then check from email of Donor

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Slack Call Summary

Participants: @nishitlangaliya @kevinwhoffman
Topic: Behavior of dat filters when a non-default date format is selected
Result: Nishit demonstrated how the date filters have no effect if a non-default date format is selected in WP settings. He will move forward with fixing these date filters in both Donations and Donors screens. Acceptance criteria updated.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

@nishitlangaliya See updated acceptance criteria regarding notes from today's team call.

@nishitlangaliya

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Slack Call Summary

Participants: @nishitlangaliya @ravinderk
Topic: Search by Donor ID was not working
Result: I had a discussion with @ravinderk and found search by Donor ID was not working and after selecting correct base branch I got conflict so solving it and push the code.

@ravinderk ravinderk closed this Nov 12, 2018

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Nov 12, 2018

Reopening this issue for #3808 (comment)

@ravinderk ravinderk reopened this Nov 12, 2018

@ravinderk ravinderk self-assigned this Nov 12, 2018

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Nov 12, 2018

@ravinderk ravinderk closed this Nov 12, 2018

ravinderk added a commit that referenced this issue Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.