New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools > Data: Confirmation Checkbox and Submit button needs to be in sync #2195

Closed
mehul0810 opened this Issue Oct 13, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@mehul0810
Contributor

mehul0810 commented Oct 13, 2017

Issue Overview

I've noticed that selecting Delete Imported Donors and Payments under Tools > Data then it asks user to confirm that Are you sure you want to delete using a checkbox. But, for the first user is asked for confirmation and then user is able to click submit for deletion as many times user wants.
Please refer the attached GIF.

gif

P.S: while capturing GIF, there is no imported data so it is showing No Data Found everytime. However, there is no issue.

Expected Behavior

User should be asked for confirmation each time user clicks on submit for deleting any sensitive data.

Current Behavior

Currently, user is asked for confirmation for deleting sensitive data for the first time.

Todos

  • Tests
  • Documentation
@BhargavBhandari90

This comment has been minimized.

Contributor

BhargavBhandari90 commented Oct 13, 2017

@mehul0810 I would say form should be reset after submit each time.

BhargavBhandari90 added a commit to BhargavBhandari90/Give that referenced this issue Oct 13, 2017

Fix - issue impress-org#2195
Reset recount stats form after submit

@DevinWalker DevinWalker added this to the 1.8.15 milestone Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment