New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If more than one form is embedded on the page using radio multi-level amounts it causes jumping #2292

Closed
DevinWalker opened this Issue Nov 3, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@DevinWalker
Member

DevinWalker commented Nov 3, 2017

Issue Overview

When you have more than one donation form embedded on the page and they are both using the Radio "Display Style" it causes jumping from the second form to the first:

2017-11-03_12-37-21

Expected Behavior

  • Multiple forms sharing the same display style can be embedded on the page without issue

Current Behavior

  • When more than one form is embedded on the page it causes an issue.

Possible Solution

  1. Use the $form_id variable to make it unique - although this would likely cause the issue if the same form is embedded twice duplicating the ID
  2. Create a unique ID per form output and use that within the IDs

Steps to Reproduce (for bugs)

  1. Created two or more multi-level donations forms
  2. Each should be using the Radio display style
  3. Embed them on the page
  4. Preview the page

@DevinWalker DevinWalker added the bug label Nov 3, 2017

@DevinWalker DevinWalker added this to the 1.8.17 milestone Nov 3, 2017

@DevinWalker DevinWalker self-assigned this Nov 3, 2017

@ravinderk ravinderk referenced this issue Nov 8, 2017

Merged

Issues/2305 #2307

3 of 3 tasks complete

@ravinderk ravinderk added the has pr label Nov 8, 2017

@ravinderk ravinderk self-assigned this Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment