Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): Add shortcode support to Offline Donations Instructions output #2937

Closed
mathetos opened this issue Mar 21, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@mathetos
Copy link
Member

commented Mar 21, 2018

User Story

As an admin, I want to output content from other plugins via a shortcode into my Offline Donations instructions so that I can have more flexibility in the instructions presentation.

User highlighted this problem here:
https://wordpress.org/support/topic/enable-shortcodes-in-offline-instructions/

Current Behavior

I currently cannot do that, see here:
image

Expected Behavior

I expect that what appears in the admin, would appear on the frontend as well. The shortcodes render in the admin correctly, but not the front-end. See here:
image

I also expect that if this isn't currently available, I can customize this with a filter, but that also appears to be unavailable.

Possible Solution

Use apply_filters('the_content');

Change this line:
https://github.com/WordImpress/Give/blob/release/2.0.7/includes/gateways/offline-donations.php#L469

To this:
$global_offline_instruction = apply_filters('the_content', give_get_option( 'global_offline_donation_content' ));

Steps to Reproduce

  1. Insert a shortcode into either the global Offline instructions, or the per-form instructions
  2. View the instructions on the front-end and you'll see the naked shortcode

Related

Tasks

  • Implement the code change cited above.
  • Ensure the results are the same for both the Global Offline content, and the per-form Offline content.
  • Review all other WYSIWYG outputs throughout Give core for anywhere that we don't use the the_content filter and update as well. We should ensure that the frontend output matches expectations with the backend, and this issue has come up previously (see "Related" above).
  • Consider adding additional filters to the output for further customization.

@mathetos mathetos added the 1-reported label Mar 21, 2018

ravinderk added a commit that referenced this issue Jun 14, 2018

Merge pull request #3357 from WordImpress/issue-2937
fix(form): Add shortcode support to Offline Donations Instructions output #2937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.