Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(donation): Modal and Button display modes improperly showing payment errors #3006

Closed
samsmith89 opened this issue Apr 6, 2018 · 0 comments

Comments

Projects
None yet
5 participants
@samsmith89
Copy link

commented Apr 6, 2018

User Story

As a donor, I want to be able to see when my card was declined so that I can either use a different card or ensure it was input correctly.

Current Behavior

I currently see the modal window cover the error when the card is declined in Modal mode. When I use Button mode the modal window disappears and I need to reopen it again to see the error.

Expected Behavior

I expect to be presented immediately with an error so that I can take further action.

Steps to Reproduce

For the Modal display:

  1. Put the form into Modal display mode
  2. Process a test payment that will return a "card declined error"
  3. Notice that the modal window goes away and immediately comes back empty with the error being displayed on the page beneath it.

For the Button display:

  1. Put the form into Button display mode.
  2. Process a test payment that will return a "card declined error"
  3. Notice that the window disappears with no redirection to another page. When you select the button again there will be a "card declined" error at the top of the window.

Visuals

Screencast of the issue:
https://youtu.be/-FkOVtVOWyU

Related

https://secure.helpscout.net/conversation/555556439/16530?folderId=1823994

Environment

WordPress System Info ### WordPress Environment ###

Home URL: http://give.local
Site URL: http://give.local
WP Version: 4.9.5
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.local
TLS Connection: Connection uses The website calling howsmyssl.com's API has been making many calls and does not have a subscription. See https://subscriptions.howsmyssl.com/signup for how to get one.
TLS Connection:
Server Info: Apache/2.4.10 (Debian)
PHP Version: 7.0.3
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.0.6
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation ReceiptNew Offline DonationOffline Donation Instructions✔New User Registration✔User Registration Information✔Email accessRenewal Receipt EmailSubscription Cancelled Email
Upgraded From: 2.0.7
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://give.local/donation-confirmation/
Failure Page: http://give.local/donation-failed/
Donation History Page: http://give.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Authorize.net, Stripe - Credit Card
Default Payment Gateway: Stripe - Credit Card
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Give - Authorize.net Gateway: Unlicensed – by WordImpress – 1.3.3
Give - Braintree Gateway: Unlicensed – by WordImpress – 1.2
Give - CSV Toolbox: Unlicensed – by WordImpress – 1.0
Give - Fee Recovery: Unlicensed – by WordImpress – 1.5
Give - Form Field Manager: Unlicensed – by WordImpress – 1.2.8
Give - Manual Donations: Unlicensed – by WordImpress – 1.3.2
Give - PayPal Pro Gateway: Unlicensed – by WordImpress – 1.1.4
Give - PDF Receipts: Unlicensed – by WordImpress – 2.2.5
Give - Per Form Gateways: Unlicensed – by WordImpress – 1.0.1
Give - Recurring Donations: Unlicensed – by WordImpress – 1.5.7
Give - Sofort Payment Gateway: Unlicensed – by WordImpress, CoachBirgit – 1.0
Give - Stripe Gateway: Unlicensed – by WordImpress – 1.5.2
Give - Tributes: Unlicensed – by WordImpress – 1.4.1

Other Active Plugins

Email Cop: by Ashfame – 0.1.1
Give - Hook Helper: by Ravinder Kumar – 1.0
Sam's Helper Function: by WordImpress – 1.0
Transients Manager: by Pippin Williamson – 1.7.4
WP Auto Login: by Ren Ventura – 1.0.1

Inactive Plugins

Duplicate Post: by Enrico Battocchi – 3.2.1
Give - Currency Switcher: by WordImpress – 1.0.3
Give - Custom Field Integration: by WordImpress – 1.0
My Custom Functions: by Arthur Gareginyan – 4.13

Theme

Name: Twenty Seventeen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome

@DevinWalker DevinWalker modified the milestones: Sprint: 2018/05/08 - 2018/05/22, Sprint: 2018/05/08 - 2018/06/05 May 23, 2018

ravinderk added a commit that referenced this issue Jun 21, 2018

Merge pull request #3394 from WordImpress/issue/3006
fix(donation): Modal and Button display modes improperly showing payment errors #3006

@ravinderk ravinderk closed this Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.