New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-shortcode): Total goal attribute should be required field for [give_totals] #3060

Closed
mehul0810 opened this Issue Apr 18, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@mehul0810
Contributor

mehul0810 commented Apr 18, 2018

User Story

As an admin, I want Total Goal attribute of [give_totals] shortcode should be required so that I can see a positive goal and progress bar visible on the front end.

Current Behavior

I currently can't see the progress bar and can see goal amount to be $0 when the total_goal attribute is not provided with [give_totals] shortcode.

Expected Behavior

I expect to have the total goal attribute to be required field for [give_totals] shortcode.

Visuals

Admin end - Popup of [give_totals] shortcode
image

Frontend - When total goal attribute is not provided in [give_totals] shortcode.
image

Frontend - When total goal attribute is provided in [give_totals] shortcode
image

Related

Tasks

  • Make the total goal attribute required field for [give_totals] shortcode.
  • Testing

@DevinWalker DevinWalker removed this from the Sprint: 2018/05/23 - 2018/06/05 milestone May 30, 2018

ravinderk added a commit that referenced this issue May 30, 2018

Merge pull request #3283 from raftaar1191/issue-3060
fix(admin-shortcode): Total goal attribute should be required field for [give_totals] #3060

@ravinderk ravinderk closed this May 30, 2018

@ravinderk ravinderk reopened this May 30, 2018

@ravinderk

This comment has been minimized.

Collaborator

ravinderk commented May 30, 2018

@raftaar1191 create pr for this issue again and take release/2.1.4 as parent

@raftaar1191

This comment has been minimized.

Member

raftaar1191 commented May 30, 2018

Sure @ravinderk here is the new PR link for the issues #3284

ravinderk added a commit that referenced this issue May 30, 2018

Merge pull request #3284 from raftaar1191/issues-3283
fix(admin-shortcode): Total goal attribute should be required field for [give_totals] #3060
@mehul0810

This comment has been minimized.

Contributor

mehul0810 commented Jun 4, 2018

I'm re-opening this issue as we are showing validation error notice. But, the warning notice is shown instead of error notice.

Tasks to implement

  • Change Warning notice to Error notice
  • After clicking OK on notice, the validated field should get focus.
@raftaar1191

This comment has been minimized.

Member

raftaar1191 commented Jun 4, 2018

@mehul0810 @ravinderk

As discussed with @ravinderk on call, we will be going to take care of point number 2 After clicking OK on notice, the validated field should get focus. in #3060 (comment) by @mehul0810 in the following issues

ravinderk added a commit that referenced this issue Jun 4, 2018

Merge pull request #3319 from raftaar1191/refix-3282
fix(shortcode): select donation form alert must be open using modal api #3282 #3060

@ravinderk ravinderk closed this Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment