Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-donation): form earnings does not update when change donation amount #3085

Closed
ravinderk opened this issue Apr 23, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@ravinderk
Copy link
Collaborator

commented Apr 23, 2018

User Story

As an admin, I want form earning update when donation amount update so that I do not have to use data tools to check latest stats.

Current Behavior

Form earning is not changing when updating donation amount.

Possible Solution

Run this condition when donation amount update: https://github.com/WordImpress/Give/blob/release/2.1/includes/payments/class-give-payment.php#L970

Tasks

  • Update logic to update form earning when donation amount update.

Tests

  • After updating donation amount, review following:
    • Review form earnings
    • Review total donor donated the amount
  • Test with recurring renewal donation payment
@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 21, 2018

In favor of #3389 (comment)

@ravinderk ravinderk closed this Jun 21, 2018

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Jun 22, 2018

@ravinderk I am able to reproduce this issue. I am adding a video to show you on how we can reproduce this issues

Video Link: https://screencast-o-matic.com/watch/cF13fPFDhV

@raftaar1191 raftaar1191 reopened this Jun 22, 2018

ravinderk added a commit that referenced this issue Jun 22, 2018

Merge pull request #3396 from /issues/3085
fix(admin-donation): form earnings does not update when change donation amount #3085
@raftaar1191

This comment has been minimized.

Copy link
Member

commented Jun 22, 2018

Slack Call Summary

Participants: @raftaar1191, @ravinderk
Topic: Reopening this issues
Result: Reopening this issues as we can reproduce this issues over the call and also @ravinderk showed to me some of give function which already does increment and decrement for Form total earning so we do not need to make a new function for that. So closing the PR #3389 and created a new one #3396 for the above issues

@ravinderk ravinderk closed this Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.