Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(donation): ensure minimum donation is accurate with , separator #3176

Closed
samsmith89 opened this issue May 4, 2018 · 0 comments

Comments

Projects
None yet
4 participants
@samsmith89
Copy link

commented May 4, 2018

User Story

As a site admin, I want to set a minimum donation amount that functions correctly when I change the decimal separator to ",".

Current Behavior

I currently set a minimum donation amount with the decimal separator in Give to "," the minimum donation amount adds "00"
An example would be setting a minimum donation to $5,00 and when you input an amount the error displays that the minimum amount is $500,00

Expected Behavior

I expect to set a minimum amount for the form and have it function properly.

Steps to Reproduce

  1. Change the decimal separator to ","
  2. Set a minimum donation amount of $5,00
  3. See that the error throws inappropriately

Visuals

screen shot 2018-05-04 at 1 52 29 pm

Screencast of issue:
https://youtu.be/vj7Lp7uELMg

Related

https://secure.helpscout.net/conversation/573498477/17861?folderId=1823994

Environment

WordPress System Info ### WordPress Environment ###

Home URL: http://give.local
Site URL: http://give.local
WP Version: 4.9.5
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.10 (Debian)
PHP Version: 7.0.3
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.1.1
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation ReceiptNew Offline DonationOffline Donation Instructions✔New User Registration✔User Registration Information✔Email accessRenewal Receipt EmailSubscription Cancelled Email
Upgraded From: 2.0.6
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: ,
Thousands Separator: .
Success Page: http://give.local/donation-confirmation/
Failure Page: http://give.local/donation-failed/
Donation History Page: http://give.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, 2Checkout
Default Payment Gateway: Test Donation
PayPal IPN Verification: Disabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Give - 2Checkout Gateway: Unlicensed – by WordImpress – 1.1.1
Give - Authorize.net Gateway: Unlicensed – by WordImpress – 1.3.3
Give - Braintree Gateway: Unlicensed – by WordImpress – 1.2
Give - CSV Toolbox: Unlicensed – by WordImpress – 1.0
Give - Donation Plugin: Unlicensed – by WordImpress – 2.1.1
Give - Fee Recovery: Unlicensed – by WordImpress – 1.5
Give - Form Field Manager: Unlicensed – by WordImpress – 1.3
Give - Google Analytics Donation Tracking: Unlicensed – by WordImpress – 1.1.4
Give - MailChimp: Unlicensed – by WordImpress – 1.4
Give - Manual Donations: Unlicensed – by WordImpress – 1.3.2
Give - PayPal Pro Gateway: Unlicensed – by WordImpress – 1.1.4
Give - PDF Receipts: Unlicensed – by WordImpress – 2.2.5
Give - Per Form Gateways: Unlicensed – by WordImpress – 1.0.1
Give - Recurring Donations: Unlicensed – by WordImpress – 1.5.7
Give - Sofort Payment Gateway: Unlicensed – by WordImpress, CoachBirgit – 1.0
Give - Stripe Gateway: Unlicensed – by WordImpress – 1.5.2
Give - Tributes: Unlicensed – by WordImpress – 1.4.1

Other Active Plugins

Email Cop: by Ashfame – 0.1.1
Give - Hook Helper: by Ravinder Kumar – 1.0
Health Check: by The WordPress.org community – 1.0.1
Sam's Helper Function: by WordImpress – 1.0
Transients Manager: by Pippin Williamson – 1.7.4
User Role Editor: by Vladimir Garagulya – 4.40.3
WP Auto Login: by Ren Ventura – 1.0.1

Inactive Plugins

Duplicate Post: by Enrico Battocchi – 3.2.1
Give - Currency Switcher: by WordImpress – 1.0.3
Give - Custom Field Integration: by WordImpress – 1.0
Give - Gift Aid: by WordImpress – 1.1.1
Give - PayFast Payment Gateway: by WordImpress – 1.0
My Custom Functions: by Space X-Chimp – 4.15
WP Google Maps: by WP Google Maps – 7.0.02
WP Google Maps - Pro Add-on: by WP Google Maps – 5.73

Active MU Plugins

Bypass Login: by Stephen Carnam – 1.1.0
Health Check Disable Plugins: by – 1.3

Theme

Name: Twenty Seventeen
Version: 1.5
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome

@kevinwhoffman kevinwhoffman added the urgent label May 4, 2018

@kevinwhoffman kevinwhoffman changed the title fix(donation): Changing decimal separator to "," causes minimum donation not to work fix(donation): ensure minimum donation is accurate with , separator May 4, 2018

DevinWalker added a commit that referenced this issue May 4, 2018

Merge pull request #3182 from raftaar1191/issue-3176
fix(donation): ensure minimum donation is accurate with , separator #3176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.