Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(admin): add notice to add-ons warning to always check if Give Core is up-to-date. #3217
Every major release, the support team gets a handful of tickets from customers panicking because their forms are broken, when in reality it is simply that they updated add-ons before updating core, and the add-ons deactivate themselves.
I currently click through and update the plugins, and if I go alphabetically and I am using the Give Authorize.net add-on, it updates before the Give Donation plugin and deactivates itself if it doesn't pass the minimum give version test.
I expect to be warned if a new update to Give core is necessary before updating an add-on.
Since the minimum give version check technically happens in the add-on code, this might require issues in each add-on repo, but I was thinking about a way to add aWarning any time Give Core is not on the latest stable version to the top of the plugins page, or to the top of each add-on's listing (search for
Steps to Reproduce
@DevinWalker Here are my suggestion to resolve this issue:
I think we do not need to add code to each addon to show warnings it can be done by core only. To achieve that I need following data:
We can insert this information into
I will prefer to show two notice:
@ravinderk This looks good to me. The add-on notice example shown under Give - Email Reports will be a welcome addition.
But I have some concerns about the Give core notice demonstrated here:
My understanding is the notice would alert the user to a list of add-ons with
A Give core update is usually accompanied by a few add-on updates, however the majority of add-ons are not updated alongside every Give core update (which means their
This also doesn't resolve the issue of people updating add-ons remotely and never seeing the notice. @ravinderk let's discuss when you get online. Remember, the major issue here is people updating add-ons that require a higher give version that they are not running and then the add-on deactivating. That's what needs to be resolved.
@DevinWalker I got you.
I researched on how WordPress updates plugin by ajax.
We can use
To review how we can remotely update the plugin, I reviewed https://wordpress.org/plugins/shift8-remote-update/ plugin and found that they are following WordPress logic:
@rafftar We do not need to create API for that. we have access to readme.txt which we can read.
referenced this issue
May 28, 2018
@raftaar1191 We can not do this here because WordPress fire bulk update hook here, in