Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): ensure state field styles don't break when changing country #3255

Closed
samsmith89 opened this issue May 23, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@samsmith89
Copy link

commented May 23, 2018

User Story

As a donor, in the billing details, I want to change the country without the State field styles breaking so that form display is consistent.

Current Behavior

I currently get different styles applied to the State field in the billing details when I change the country and try to change back.

It works currently in twenty seventeen, but when you change to any other theme this functionality breaks.

Expected Behavior

I expect to be able to change the country and the form styles stay consistent.

Steps to Reproduce

  1. Make sure the WP install is on any other theme besides twenty seventeen.
  2. Turn floating labels and billing details on in your form
  3. In the billing details change the country to anything besides US and then change it back.
  4. See that the State field isn't displaying properly

Visuals

For this example, I used twenty sixteen.

Before changing country:
screen shot 2018-05-23 at 11 35 38 am

After changing country back
screen shot 2018-05-23 at 11 35 28 am

Screencast of the issue:
https://youtu.be/KhmUPJ2HhNM

Related

https://secure.helpscout.net/conversation/577717254/18167?folderId=1823994

Environment

WordPress System Info ### WordPress Environment ###

Home URL: http://give.local
Site URL: http://give.local
WP Version: 4.9.5
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.10 (Debian)
PHP Version: 7.0.3
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.1.2
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email accessRenewal Receipt EmailSubscription Cancelled Email
Upgraded From: 2.0.6
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://give.local/donation-confirmation/
Failure Page: http://give.local/donation-failed/
Donation History Page: http://give.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, PayPal Payments Pro, Authorize.net eCheck (ACH), Stripe + Plaid, Braintree, Offline Donation, Stripe - Credit Card
Default Payment Gateway: Stripe - Credit Card
PayPal IPN Verification: Disabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Give - 2Checkout Gateway: Unlicensed – by WordImpress – 1.1.1
Give - Authorize.net Gateway: Unlicensed – by WordImpress – 1.4.1
Give - Braintree Gateway: Unlicensed – by WordImpress – 1.2.1
Give - Donation Plugin: Unlicensed – by WordImpress – 2.1.2
Give - Fee Recovery: Unlicensed – by WordImpress – 1.6
Give - Form Field Manager: Unlicensed – by WordImpress – 1.3
Give - Google Analytics Donation Tracking: Unlicensed – by WordImpress – 1.1.4
Give - MailChimp: Unlicensed – by WordImpress – 1.4.1
Give - Manual Donations: Unlicensed – by WordImpress – 1.4
Give - PayPal Pro Gateway: Unlicensed – by WordImpress – 1.1.5
Give - PDF Receipts: Unlicensed – by WordImpress – 2.3
Give - Per Form Gateways: Unlicensed – by WordImpress – 1.0.1
Give - Recurring Donations: Unlicensed – by WordImpress – 1.6.1
Give - Sofort Payment Gateway: Unlicensed – by WordImpress, CoachBirgit – 1.0
Give - Stripe Gateway: Unlicensed – by WordImpress – 2.0.3
Give - Tributes: Unlicensed – by WordImpress – 1.4.2

Other Active Plugins

Duplicate Post: by Enrico Battocchi – 3.2.2
Give - Hook Helper: by Ravinder Kumar – 1.0
Health Check: by The WordPress.org community – 1.0.1
Popup Maker: by WP Popup Maker – 1.7.19
Sam's Helper Function: by WordImpress – 1.0
Transients Manager: by Pippin Williamson – 1.7.4
User Role Editor: by Vladimir Garagulya – 4.40.3
WP Auto Login: by Ren Ventura – 1.0.1

Inactive Plugins

Email Cop: by Ashfame – 0.1.1
GEO my WP: by Eyal Fitoussi – 3.0.4
Give - CSV Toolbox: by WordImpress – 1.0
Give - Currency Switcher: by WordImpress – 1.1
Give - Custom Field Integration: by WordImpress – 1.0
Give - Gift Aid: by WordImpress – 1.1.2
Give - PayFast Payment Gateway: by WordImpress – 1.0.1
Give - Paymill Gateway: by WordImpress – 1.1
My Custom Functions: by Space X-Chimp – 4.16
WP Google Maps: by WP Google Maps – 7.0.02
WP Google Maps - Pro Add-on: by WP Google Maps – 5.73
WP Mail SMTP: by WPForms – 1.2.5
WPML String Translation: by OnTheGoSystems – 2.7.3

Active MU Plugins

Bypass Login: by Stephen Carnam – 1.1.0
Health Check Disable Plugins: by – 1.3

Theme

Name: Twenty Sixteen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome

ravinderk added a commit that referenced this issue May 30, 2018

Merge pull request #3287 from raftaar1191/refix-3255
 fix(form): ensure state field styles don't break when changing country #3255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.