New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(sessions): research use of PHP sessions throughout Give #3272

Closed
joehoyle opened this Issue May 28, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@joehoyle

joehoyle commented May 28, 2018

Almost a duplicate of #521, which was fixed but appears to be back.

Specifically it was fixed by this commit https://github.com/WordImpress/Give/pull/552/files#diff-d3edc19fec3fdac5e9147093267b2515R109, but then this was essentially reverted on 243c025 which brought back the problem.

#1630 also looks like potentially a dupe, but not sure if that's more about how the sessions are stored.

The main issue here is that each page load on the front end causes a setcookie which means you pretty much can't cache any page, as every request will then have a wp_session cookie. From what I can see (please correct me if I'm wrong) it's not really possible to use Give in a high traffic environment, as this pretty much necessities multiple web servers (therefore needing to use cookie sessions) and each request causes a cache bypass due to sessions being initiated for every visitor of the WordPress site.

@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Jun 1, 2018

Member

@joehoyle Thanks for taking the time to detail the issue and potentially related ones. I've assigned @ravinderk to look into this further.

@ravinderk Please review the behavior Joe is describing and the related issues. Then post your recommended solution here. Thanks!

Member

kevinwhoffman commented Jun 1, 2018

@joehoyle Thanks for taking the time to detail the issue and potentially related ones. I've assigned @ravinderk to look into this further.

@ravinderk Please review the behavior Joe is describing and the related issues. Then post your recommended solution here. Thanks!

@vinnygreen

This comment has been minimized.

Show comment
Hide comment
@vinnygreen

vinnygreen Jun 8, 2018

@ravinderk @kevinwhoffman Any progress on this issue? Is there anything you need from us?

vinnygreen commented Jun 8, 2018

@ravinderk @kevinwhoffman Any progress on this issue? Is there anything you need from us?

@mathetos

This comment has been minimized.

Show comment
Hide comment
@mathetos

mathetos Jun 8, 2018

Member

Hey @vinnygreen We're putting the research into this to find the right approach to it. We'll report on our approach on it early next week.

Member

mathetos commented Jun 8, 2018

Hey @vinnygreen We're putting the research into this to find the right approach to it. We'll report on our approach on it early next week.

@vinnygreen

This comment has been minimized.

Show comment
Hide comment
@vinnygreen

vinnygreen Jun 8, 2018

Thanks for the update!

vinnygreen commented Jun 8, 2018

Thanks for the update!

@kevinwhoffman kevinwhoffman changed the title from Sessions are started on every page view to perf(sessions): optimize use of PHP sessions throughout Give Jun 8, 2018

@kevinwhoffman kevinwhoffman changed the title from perf(sessions): optimize use of PHP sessions throughout Give to perf(sessions): research use of PHP sessions throughout Give Jun 8, 2018

@ravinderk

This comment has been minimized.

Show comment
Hide comment
@ravinderk

ravinderk Jun 20, 2018

Collaborator

@joehoyle @vinnygreen We researched the session issue and found that Woocommerce already has a session solution which is tested it on wootheme.com before merging to Woocommerce plugin.

We are going to use Woocommerce sesison codebase as intial.

Ref: https://woocommerce.wordpress.com/2015/10/07/new-session-handler-in-2-5/

Collaborator

ravinderk commented Jun 20, 2018

@joehoyle @vinnygreen We researched the session issue and found that Woocommerce already has a session solution which is tested it on wootheme.com before merging to Woocommerce plugin.

We are going to use Woocommerce sesison codebase as intial.

Ref: https://woocommerce.wordpress.com/2015/10/07/new-session-handler-in-2-5/

@ravinderk ravinderk referenced this issue Jun 20, 2018

Closed

feat(sessions): implement sessions #3386

23 of 33 tasks complete
@ravinderk

This comment has been minimized.

Show comment
Hide comment
@ravinderk

ravinderk Jun 20, 2018

Collaborator

Closing this issue in favor of #3386

Collaborator

ravinderk commented Jun 20, 2018

Closing this issue in favor of #3386

@ravinderk ravinderk closed this Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment