Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): Be more specific with .notice-dismiss class #3337

Closed
mathetos opened this issue Jun 8, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@mathetos
Copy link
Member

commented Jun 8, 2018

User Story

As a Give user, I expect that the Give styles will be strong enough to avoid problems like this:

image

Current Behavior

Currently, this style is very generic, it's just .notice-dismiss so it can easily get over-written by other themes or plugins like in the example above.

Expected Behavior

I expect that Give can avoid this by being more specific in the notices style.

Possible Solution

Here's a couple options:

  1. img[class*="give"].notice-dismiss {}
  2. p.give_notice img.notice-dismiss {}
  3. div.give_notices img.notice-dismiss {}

Any of those would help prevent the problem shown above.

Related

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Jun 8, 2018

@Sidsector9 Update this CSS rule to match the example below. Ideally the class would be prefixed, but we are using it throughout the add-ons so just update the selector and add !important like so:

.give-notice .notice-dismiss {
    ...
    max-width: 28px !important;
    ...
}

Please also ensure that the alert in currency switcher has a green bar with green icon. It is currently showing a red border with green icon, which is confusing and looks alarming.

This may require an issue in currency switcher add-on since it is outputting inline styles which are unnecessary because they are already in the front-end stylesheet. If necessary, create an issue for the add-on and address it. Thanks.

Current

image

Proposed

image

kevinwhoffman added a commit that referenced this issue Jun 11, 2018

Merge pull request #3343 from WordImpress/issue-3337
fix(form): Be more specific with .notice-dismiss class #3337
@raftaar1191

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

Slack Call Summary

Participants: @Sidsector9 , @raftaar1191
Topic: Able to regenerate this issues
Result: As discussed over the call with @Sidsector9 I am reopening this issues and @Sidsector9 is going to fix this issues

Finding

After making a donation to any other current expect the default one and then again try to make a donation is see the following issue

This issues may be related to: #3337

Video Link: https://screencast-o-matic.com/watch/cF12XjFivB

image

@raftaar1191 raftaar1191 reopened this Jun 14, 2018

ravinderk added a commit that referenced this issue Jun 14, 2018

Merge pull request #3368 from WordImpress/issue/3337
fix(form): Be more specific with .notice-dismiss class #3337
@raftaar1191

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

Testing

When testing the Give Core 2.1.5 I find it out that with currency switcher is on we are still getting this issues

image

@raftaar1191 raftaar1191 reopened this Jun 18, 2018

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

Slack Call Summary

Participants: @Sidsector9 , @raftaar1191
Topic: Regenerate this issues
Result: Had an call with @Sidsector9 and try to regenerate this issues but not able to regenerate this so closing this issues for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.