New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sessions): implement sessions #3386

Closed
ravinderk opened this Issue Jun 20, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@ravinderk
Collaborator

ravinderk commented Jun 20, 2018

User Story

ref #3272 (comment)

Tasks

  • Add logic to store session in DB
  • Cache session data
  • Add session invalidation logic
  • Add Backward compatibility ( if needed )
  • Deprecated
    • no need to $prefix because we are not setting $_SESSION. prefix was using for setting unique key in $_SESSION
    • $use_php_sessions
    • deprecated GIVE_USE_PHP_SESSIONS
    • use_php_sessions function. Return false with give_doing_it_wrong fn
    • should_start_session no need of this fn
    • set_expiration_variant_time no need of this fn
    • get_id no need
  • Remove session information from system info page
  • Add db upgrade to remove existing session data from wp_options table
  • Developer blog post

Test

@ravinderk ravinderk self-assigned this Jun 20, 2018

DevinWalker added a commit that referenced this issue Jun 26, 2018

Merge pull request #3387 from /issues/3386
feat(sessions): implement sessions #3386

@raftaar1191 raftaar1191 referenced this issue Jul 12, 2018

Closed

qa(give): ensure quality of Give 2.2 #3467

33 of 33 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment