Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): DB Update notice appears on fresh install #3390

Closed
mathetos opened this issue Jun 20, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@mathetos
Copy link
Member

commented Jun 20, 2018

User Story

As a brand new Give user, I don't expect to be notified of the need to update my database on activation of the plugin for the first time. It should work out of the box immediately after activation.

Current Behavior

Currently, new Give users see the DB Update notice immediately after activating the plugin for the first time.

Expected Behavior

I expect that all new DB tables are created silently as soon as Give is activated for the first time.

Possible Solution

Create the new tables silently without a notification.

Steps to Reproduce

  1. Create a fresh install
  2. Install Give from "Plugins > Add New" (not Github)
  3. Activate and confirm that the DB notice is there.
@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Jun 20, 2018

@ravinderk I confirmed the DB notice is present on a fresh install of Give 2.1.5. Please let us know why this might be happening and move it to the top of your priority list so we can get a 2.1.6 patch out as soon as possible. Thanks.

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2018

Closing in favor of 7a17b22

@ravinderk ravinderk closed this Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.