Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exports): remove the restriction of when the form is created from the PDF receipt export in Core #3395

Closed
Benunc opened this issue Jun 21, 2018 · 0 comments

Comments

Projects
None yet
5 participants
@Benunc
Copy link
Member

commented Jun 21, 2018

User Story

As a site admin, I want the pdf export in core at Donations > Tools > Export > Export PDF of Donations and Income to export donations from the current year instead of donations for forms created in the current year.

The current implementation is confusing. If a form was created in 2016, and has donations on it yesterday, I would expect those donations to be included in the PDF.

Current Behavior

Currently the only forms included in the query are ones created this year: https://github.com/WordImpress/Give/blob/master/includes/admin/tools/export/pdf-reports.php#L119

Expected Behavior

I expect the form creation date to not factor in, instead to only count donations that can in this year for that PDF.

Possible Solution

Remove the check for the year created on the form, or clarify the language on the export page.

Steps to Reproduce

  1. Create a donation form, and set the created date to before this year.
  2. Create several donations on this form for various dates, some before and some after this year
  3. Export the PDF at Donations > Tools > Export > Export PDF of Donations and Income to export donations from the current year

I would expect, from the wording there, for the donations made to the old form within this year to be exported, but the older ones to be excluded.

Related

Tasks

  • remove the restriction of the form created date in the query
  • ensure that donation date is included in the query, and limit donation date to the current year.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.