Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emails): remove Give Shortcode button from the editor for creating emails #3422

Closed
Benunc opened this issue Jun 29, 2018 · 2 comments

Comments

Projects
None yet
5 participants
@Benunc
Copy link
Member

commented Jun 29, 2018

User Story

As a give admin, I don't want options to add Give Shortcodes to emails because shortcodes don't work in emails.

Currently, when I navigate to Donations > Settings > Emails and select one of the emails to edit, there is an option to add give shortcodes to the emails.

If I am new to Give, I might think those are appropriate spots for Give shortcodes.

Current Behavior

I currently see the option for adding shortcodes to emails.

Expected Behavior

I expect to not be given the option to add shortcodes where they won't work.

Steps to Reproduce

  1. Latest Master
  2. Navigate to Donations > Settings > Emails (tab) and select an email to edit
  3. There is a shortcode button there.

Visuals

screen shot 2018-06-29 at 6 43 40 am

Related

Tasks

  • remove the button from the visual tinymce editor on each email
  • remove the button from the text tinymce editor
  • confirm that the solution is extensible: emails added by add-ons also do not get the shortcode button
@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2018

@Benunc @DevinWalker I think we should remove Give Shortcodes button from all setting pages because it will add to all wp editor, not just email.

image

Note: We can use give_shortcode_button_condition filter to show Give Shortcodes on custom pages

@ravinderk ravinderk reopened this Jul 9, 2018

ravinderk added a commit that referenced this issue Jul 9, 2018

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2018

Closing in favor of cd544dd

@ravinderk ravinderk closed this Jul 9, 2018

@raftaar1191 raftaar1191 referenced this issue Jul 12, 2018

Closed

qa(give): ensure quality of Give 2.2 #3467

33 of 33 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.