Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gutenberg): error notices shouldn't display on Gutenberg #3575

Closed
DevinWalker opened this issue Aug 7, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@DevinWalker
Copy link
Member

commented Aug 7, 2018

User Story

As an admin I don't want Give error notices displaying on my Gutenberg editor.

2018-08-06_17-07-23

Current Behavior

Error notices display and are not dismissible.

Expected Behavior

Error notices do not appear and disturb my editing.

@Sidsector9

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

@DevinWalker I'm not able to reproduce this issue, can you have a look at this video -

https://www.useloom.com/share/c96fbc3fc4324208a466176b92e7723e

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2018

@Sidsector9 you said you couldn't reproduce it with a video then submitted a PR. This is confusing to me when reviewing. You should delete your comment above with an explanation about how you reproduced it or provide another form of explanation so that it's clear to me.

@Sidsector9

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

@DevinWalker , even though I'm not able to reproduce the exact issue since the notice is hidden but still rendered, @ravinderk asked to disable all global notices on the Gutenberg editor screen. Hence I submitted the PR.

This is the Slack Chat summary - https://givewp.slack.com/archives/C0FAGC83C/p1533636633000015?thread_ts=1533636447.000184&cid=C0FAGC83C

ravinderk added a commit that referenced this issue Aug 20, 2018

Merge pull request #3582 from WordImpress/issue/3575
fix(gutenberg): error notices shouldn't display on Gutenberg #3575

@raftaar1191 raftaar1191 referenced this issue Aug 30, 2018

Closed

qa(give): ensure quality of Give 2.2.4 #3642

15 of 15 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.