New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure Give add-ons appear together in System Info #3736

Closed
kevinwhoffman opened this Issue Oct 8, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@kevinwhoffman
Member

kevinwhoffman commented Oct 8, 2018

Bug Report

User Story

As a Give user, I want my System Info to correctly reflect my active Give addons so that it's clear how many Give add-ons are currently active.

Current Behavior

Currently, add-ons such as Give Stripe appear in the Other Active Plugins section of the Give System Info, instead of the Active Give Add-ons section.

Expected Behavior

I expect all Give add-ons to appear in the Active Give Add-ons section correctly.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Have Give Stripe activated
  2. Go to "Donations > Tools > System Info" and see that the Give Stripe addon appears in the wrong section.

Visuals

image

Possible Solution

The Give Stripe add-on says it is authored by "GiveWP" whereas most other Give Addons say "WordImpress". The logic of the System Info screen should be updated to include add-ons that are authored by GiveWP or WordImpress.

This code from the Plugins screen can be repurposed for use in the System Info screen: https://github.com/impress-org/give/pull/3710/files

Acceptance Criteria

  • All Give add-ons appear in the System Info under the "Give Add-ons" section
  • No Give add-ons appear additionally in the "Other Activated Plugins" section
@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Oct 8, 2018

Member

@jaydeeprami Please bump this to the top of your list so we can get this fix released with v2.3.0. See the example provided in the possible solution to save some time.

Member

kevinwhoffman commented Oct 8, 2018

@jaydeeprami Please bump this to the top of your list so we can get this fix released with v2.3.0. See the example provided in the possible solution to save some time.

ravinderk added a commit that referenced this issue Oct 9, 2018

Merge pull request #3738 from impress-org/issue/3736
fix: ensure Give add-ons appear together in System Info #3736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment