New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure quality of Give v2.3.0 #3737

Open
kevinwhoffman opened this Issue Oct 8, 2018 · 13 comments

Comments

Projects
None yet
5 participants
@kevinwhoffman
Member

kevinwhoffman commented Oct 8, 2018

Acceptance Criteria

The following acceptance criteria are based on the Give v2.3.0 Release Report.

  • Donations process after the 2.3.0 plugin update but before the database upgrade. @ravinderk
  • Donations process after both the 2.3.0 plugin update and the database upgrade. @ravinderk
  • When DB upgrade starts, donor notes are migrated to the custom comments table. @ravinderk
  • When DB upgrade starts, donation notes are migrated to the custom comments table. @ravinderk
  • When DB upgrade starts, donor comments are migrated successfully to the custom comments table. @ravinderk
  • After a fresh WP install, Give 2.3.0 can be installed with no DB upgrade notices.
  • Donor wall renders on a multisite install.
  • Multisite donor wall only includes donors from that specific child site.
  • Anonymous donations do not appear in donor wall.
  • All shortcode builder options are accurately reflected on the front end.
  • The shortcode builder modal window scrolls if it is too tall for viewport.
  • Donor wall works after npm run production.
  • While testing, no notices are generated in debug.log
  • While testing, no notices appear in the console that are caused by the plugin.
  • The issues in the 2.3.0 Testing Spreadsheet have been reviewed prior to release.
  • All of the above criteria are true with PHP 5.3 as well.
@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Oct 8, 2018

Member

@mehul0810 I ask that you create the acceptance criteria as you have experience doing so on previous releases and then test those criteria that are not marked for Ravinder.

Member

kevinwhoffman commented Oct 8, 2018

@mehul0810 I ask that you create the acceptance criteria as you have experience doing so on previous releases and then test those criteria that are not marked for Ravinder.

@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Oct 9, 2018

Member

@ravinderk I've added a few criteria that I'd like you to specifically test regarding the database upgrades. Please test those background updates one last time at scale before the release goes out.

Member

kevinwhoffman commented Oct 9, 2018

@ravinderk I've added a few criteria that I'd like you to specifically test regarding the database upgrades. Please test those background updates one last time at scale before the release goes out.

@mehul0810

This comment has been minimized.

Show comment
Hide comment
@mehul0810

mehul0810 Oct 9, 2018

Contributor

@kevinwhoffman I've updated the Acceptance Criteria with the common but essential points which are usually caught during testing.

Contributor

mehul0810 commented Oct 9, 2018

@kevinwhoffman I've updated the Acceptance Criteria with the common but essential points which are usually caught during testing.

@ravinderk

This comment has been minimized.

Show comment
Hide comment
@ravinderk

ravinderk Oct 9, 2018

Collaborator

@kevinwhoffman We found an issue with custom comment table with the manual donation addon. I will fix it by tomorrow: impress-org/give-manual-donations#135

Collaborator

ravinderk commented Oct 9, 2018

@kevinwhoffman We found an issue with custom comment table with the manual donation addon. I will fix it by tomorrow: impress-org/give-manual-donations#135

@mehul0810

This comment has been minimized.

Show comment
Hide comment
@mehul0810

mehul0810 Oct 9, 2018

Contributor

Here is the spreadsheet which I've created to resolve each issue in the release: https://docs.google.com/spreadsheets/d/1a4GOZEwraS5bOulvoxi4qibhmO_opdKSsPitU_-gdWQ/edit#gid=0

Contributor

mehul0810 commented Oct 9, 2018

Here is the spreadsheet which I've created to resolve each issue in the release: https://docs.google.com/spreadsheets/d/1a4GOZEwraS5bOulvoxi4qibhmO_opdKSsPitU_-gdWQ/edit#gid=0

@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Oct 10, 2018

Member

@mehul0810 To keep this simple, I added one criterion that links to the testing spreadsheet. See:

The issues in the 2.3.0 Testing Spreadsheet have been reviewed prior to release.

You can mark your progress in the spreadsheet for the remaining issues. Devin and I will discuss a better process for QA going forward.

Member

kevinwhoffman commented Oct 10, 2018

@mehul0810 To keep this simple, I added one criterion that links to the testing spreadsheet. See:

The issues in the 2.3.0 Testing Spreadsheet have been reviewed prior to release.

You can mark your progress in the spreadsheet for the remaining issues. Devin and I will discuss a better process for QA going forward.

@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Oct 10, 2018

Member

@ravinderk I notice that when I completed a migration from givewp.com that a bunch of akismet_result, akismet_as_submitted, and akismet_history rows are brought over. These seem to be unnecessary and cluttering up the new db table. If I'm not mistaken, we should not be migrating this data over:

2018-10-10_00-01-36

Member

DevinWalker commented Oct 10, 2018

@ravinderk I notice that when I completed a migration from givewp.com that a bunch of akismet_result, akismet_as_submitted, and akismet_history rows are brought over. These seem to be unnecessary and cluttering up the new db table. If I'm not mistaken, we should not be migrating this data over:

2018-10-10_00-01-36

@mehul0810

This comment has been minimized.

Show comment
Hide comment
@mehul0810

mehul0810 Oct 10, 2018

Contributor

Update: I've tested half of the spreadsheet issue and rest half is pending. Also, found an issue with one issue which I've re-opened and will fix it tomorrow.

Contributor

mehul0810 commented Oct 10, 2018

Update: I've tested half of the spreadsheet issue and rest half is pending. Also, found an issue with one issue which I've re-opened and will fix it tomorrow.

@ravinderk

This comment has been minimized.

Show comment
Hide comment
@ravinderk

ravinderk Oct 11, 2018

Collaborator

@DevinWalker There can be lot s of meta key we are not useful but it is difficult to identify them all.

I am removing Akismet plugin related metadata from upgrade: 95840a5...56983ba

Collaborator

ravinderk commented Oct 11, 2018

@DevinWalker There can be lot s of meta key we are not useful but it is difficult to identify them all.

I am removing Akismet plugin related metadata from upgrade: 95840a5...56983ba

@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Oct 18, 2018

Member

I completed additional testing for the donor wall, including multisite tests. I have added those acceptance criteria to the original post.

Member

kevinwhoffman commented Oct 18, 2018

I completed additional testing for the donor wall, including multisite tests. I have added those acceptance criteria to the original post.

@mehul0810

This comment has been minimized.

Show comment
Hide comment
@mehul0810

mehul0810 Oct 22, 2018

Contributor

@kevinwhoffman @DevinWalker I’ve done with testing Give Core release 2.3.0. Here is the testing report:
(1) #3638 - This issue is not working.
(2) #3588 - This issue will still have comment count issue as we are not deleting wp_comments table having to Give comments data after migration.
(3) #2350 and #3663 - These both issues are related to frontend UI testing which I’ve tried testing but the docker process stuck in between so unable to test this properly.

@kevinwhoffman I've tested the donor wall functionality without running upgrade routine as you suggested and it works fine.

I’ve discussed all the above issues with Kevin. Also, rest of the issues of the spreadsheet are working fine.

Note: Please make sure you run composer to create vendor folder for TCPDF to create production ZIP.

Contributor

mehul0810 commented Oct 22, 2018

@kevinwhoffman @DevinWalker I’ve done with testing Give Core release 2.3.0. Here is the testing report:
(1) #3638 - This issue is not working.
(2) #3588 - This issue will still have comment count issue as we are not deleting wp_comments table having to Give comments data after migration.
(3) #2350 and #3663 - These both issues are related to frontend UI testing which I’ve tried testing but the docker process stuck in between so unable to test this properly.

@kevinwhoffman I've tested the donor wall functionality without running upgrade routine as you suggested and it works fine.

I’ve discussed all the above issues with Kevin. Also, rest of the issues of the spreadsheet are working fine.

Note: Please make sure you run composer to create vendor folder for TCPDF to create production ZIP.

@kevinwhoffman

This comment has been minimized.

Show comment
Hide comment
@kevinwhoffman

kevinwhoffman Oct 23, 2018

Member

Here's the summary of directions to wrap up the 2.3.0 release. See the individual issues for more info:

  1. #3638 - @mehul0810 will move forward with a fix to ensure all of the custom tables are properly removed when Delete All Data is specified.
  2. #3588 - @ravinderk is going to modify the 2.3.0 DB upgrade to remove the comments from the wp_comments table after the migration is complete.
  3. #2350 and #3663 - UI testing should work once release/2.3.0 is merged to master.
Member

kevinwhoffman commented Oct 23, 2018

Here's the summary of directions to wrap up the 2.3.0 release. See the individual issues for more info:

  1. #3638 - @mehul0810 will move forward with a fix to ensure all of the custom tables are properly removed when Delete All Data is specified.
  2. #3588 - @ravinderk is going to modify the 2.3.0 DB upgrade to remove the comments from the wp_comments table after the migration is complete.
  3. #2350 and #3663 - UI testing should work once release/2.3.0 is merged to master.
@ravinderk

This comment has been minimized.

Show comment
Hide comment
@ravinderk

ravinderk Oct 23, 2018

Collaborator

@mehul0810 Can you review that point two completed in release/2.3.0:
540f494...6d7d246
6d7d246...4f06f47
4f06f47...995f38b

Collaborator

ravinderk commented Oct 23, 2018

@mehul0810 Can you review that point two completed in release/2.3.0:
540f494...6d7d246
6d7d246...4f06f47
4f06f47...995f38b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment