New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve donor wall shortcode builder #3745

Closed
kevinwhoffman opened this Issue Oct 10, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@kevinwhoffman
Member

kevinwhoffman commented Oct 10, 2018

Bug Report

User Story

As a user, I want to set the order of the donor wall and comment length so that the donations listed are organized in a logical order with a realistic comment length.

Current Behavior

The Donor Wall shortcode builder does not currently provide a control to set the order.

Expected Behavior

There should be an Order control with the following options:

  • Newest to Oldest with a value of DESC
  • Oldest to Newest with a value of ASC

Also note the orderby and order parameters also need updated in the code since we have agreed to show one block per donation in the donor wall. For example, ordering by donation_count no longer makes sense since we are showing all donations individually. See new acceptance criteria below.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Open shortcode builder and select Donor Wall.
  2. Note the inability to select an order.

Visuals

image

Related

#3622

Acceptance Criteria

  • An Order field is available in the shortcode builder with two options: Newest to Oldest and Oldest to Newest.
  • When order Newest to Oldest, it generates a shortcode like [give_donor_wall order="DESC"] ( no need because if we will not set order attribute then default value will be consider for order).
  • When order Oldest to Newest, it generates a shortcode like [give_donor_wall order="ASC"].
  • The orderby parameter in the [give_donor_wall] shortcode defaults to date.
  • Donations appear in chronological order on the front end according to the selected order.
  • The default Comment Length has been changed from 20 to 140 in the builder and in the code.
  • Comments are truncated with an ellipsis at the nearest complete word so that words are not cut off in the middle.

@kevinwhoffman kevinwhoffman changed the title from fix: set donor wall order in shortcode builder to fix: improve donor wall shortcode builder Oct 10, 2018

@ravinderk ravinderk closed this Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment