Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite database upgrade v201_add_missing_donors callback to prevent memory exhausted issue #3797

Closed
ravinderk opened this issue Oct 23, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@ravinderk
Copy link
Collaborator

commented Oct 23, 2018

Bug Report

User Story

As an admin, I want to update plugin old instance ( version <= 1.8.16 ) with latest without any issue.

Current Behavior

Few sites database update process stalled when process v201_add_missing_donors callback if donors are more then 1000.

ref: https://secure.helpscout.net/conversation/670275338/26121?folderId=848135

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. I have a dummy database on which I am able to reproduce this issue

Acceptance Criteria

  • Upgrade process must run smoothly on dummy database.
  • Review donors before and after upgrades.
@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 23, 2018

DevinWalker added a commit that referenced this issue Oct 23, 2018

Merge pull request #3798 from impress-org/issue/3797
fix: rewrite database upgrade v201_add_missing_donors callback to prevent memory exhausted issue #3797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.