Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve donations search #3806

Closed
nishitlangaliya opened this issue Oct 26, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@nishitlangaliya
Copy link
Member

commented Oct 26, 2018

Bug Report

User Story

As a admin, I want result based on input given in search box in donations list.

Current Behavior

Currently no result founds against the string

Expected Behavior

It should search result based on string given like firstname, lastname or string like

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Go to admin -> Donations list
  2. Try to search any string in search inputbox

Visuals

https://www.useloom.com/share/52e5c89fd91d4c9ebb90606ffa3fe9a7

Possible Solution

Acceptance Criteria

  • Make sure search box gives proper result based on any string
  • Make sure it works with combination of other filters

@kevinwhoffman kevinwhoffman changed the title fix: admin donations search box filter not functional fix: improve donations search Oct 26, 2018

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

@nishitlangaliya I confirmed I am not getting any results from this search bar either. @DevinWalker and I will discuss and provide further direction for acceptance criteria.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

@nishitlangaliya As we discussed on the team call, the donation search should work the same as the donor search. It should accept Name, Email, or Donation ID. If you are handling this behavior in another PR such as #3808, just make sure you close this issue as part of it.

@nishitlangaliya

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2018

@kevinwhoffman , Closing this issue in favor of #3808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.