Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure Give blocks are compatible with latest Gutenberg #3813

Closed
ravinderk opened this issue Oct 30, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@ravinderk
Copy link
Collaborator

commented Oct 30, 2018

Bug Report

User Story

As an admin, I want to ensure that Give blocks will work fine with WordPress future release with Gutenberg editor so that I can use Give blocks to create pages.

ref: #3697

Current Behavior

Give blocks are not working fine with WP 5.0 Beta.

Expected Behavior

Give blocks must work fine with WP 5.0 Beta or above.

Bug Type

  • This bug describes functionality that once worked as expected before 5.0 > WP.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Install latest WP version: https://wordpress.org/news/2018/10/wordpress-5-0-beta-1/
  2. Create a new page
  3. Use any of Give block. You will get an error in the browser inspector tool's console tab.

Visuals

image

Acceptance Criteria

  • Refresh React concepts.
  • Review Gutenberg API https://wordpress.org/gutenberg/handbook/.
  • Fix broken Give blocks.
    • Donation Form block
    • Donor Wall block
    • Form Grid block
  • Review settings available for editing on block setting panel for all blocks and add if anyone missing
    • Donation Form block
    • Donor Wall block
    • Form Grid block

@ravinderk ravinderk self-assigned this Oct 30, 2018

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 2, 2018

@kevinwhoffman @DevinWalker I worked on this issue and now blocks are working with WP 5.0.0 Beta but I am facing one issue. Gutenberg API somewhere caches API results before render and it will not rerender block if past query repeat. I check for a solution but did not find.

I know somewhere maybe we need to bypass this function or manually call cache deletion function: https://github.com/WordPress/gutenberg/blob/aec940810eaa73e9fe54c2a0e3dd591634158aa5/packages/data/src/resolvers-cache-middleware.js#L25

I will reach out to gutenberg pro developers and let know about it.

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 12, 2018

@kevinwhoffman or @DevinWalker can you take care of styling issues: #3827 (comment)

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

I'll create a new issue to resolve block styling issues. Leave this open for now.

@kevinwhoffman kevinwhoffman self-assigned this Nov 14, 2018

@kevinwhoffman kevinwhoffman referenced this issue Dec 4, 2018

Closed

fix: improve block styling and usability #3887

13 of 15 tasks complete
@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

Closing. Remaining block issues for WP 5.0 will be resolved in #3887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.