Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show all donations in donor wall and use "Anonymous" as the name for anon donors #3826

Closed
mathetos opened this issue Nov 2, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@mathetos
Copy link
Member

commented Nov 2, 2018

Feature Request

User Story

As a NGO using Give, I want to use the donor wall feature, but I want that all the donations appear and use the word "Anonymous Donor" when donors opt to be anonymous.

1/ if we have 10 donors listed on the wall, and their donations add up to $1000, but our Amount Raised shows $1500, that just looks weird. Like maybe we are fudging numbers.

2/ More importantly, if we have anonymous donors, at least we have donors, and other potential donors should see that donors are participating in the campaign. This creates a ‘call to action’ and ‘safety in numbers’ that helps others to decide to participate in an ‘active’ campaign as well.

It would be nice to (maybe optionally) list Anonymous Donors (anonymously, of course) 🙂 as an entry on the Donor Wall.

Possible Solution

This could be supported as an additional shortcode argument, like show_anonymous_donors=true|false

We might additionally consider another argument called show_anonmous_comments=true|false This would only apply if the first argument was true.

Related

Acceptance Criteria

  • Anonymous donations appear in the donor wall by default.
  • Anonymous donations display the following fields:
    • Amount
    • Anonymous as the name
    • Date
    • A generic user avatar
  • Comments for anonymous donations are never displayed under any condition.
  • A new shortcode parameter anonymous is available to determine the visibility of anonymous donations within the donor wall.
  • If anonymous is true (default), then anonymous donations are included.
  • If anonymous is false, then anonymous donations are excluded.
  • The shortcode builder displays the Anonymous field with values:
    • Show : true
    • Hide : false
  • The tooltip of the Anonymous field in the shortcode builder reads Determines whether anonymous donations are included.
  • The label of the front-end anonymous checkbox reads: Hide name and comment from everyone but the administrator.
  • The tooltip of the front-end anonymous checkbox reads: Would you like your donation to be displayed from an anonymous source?
  • Add anonymous attribute setting to Donor Wall Gutenberg block.
  • Hide anonymous donation if only_comments set to true. ignore anonymous attribute value.
@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

@kakshak We need to discuss with team how to handle display of anonymous donors. Acceptance criteria may change.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

On the team call we discussed displaying anonymous donations in the donor wall by default. This means if the donation was marked anonymous, then it would display:

  • Amount
  • Anonymous as the name
  • Date
  • A generic avatar

This is in line with other platforms such as GoFundMe.

We decided that anonymous comments should not be displayed for privacy purposes. However, mixing anonymous donations without comments and other donations with comments will likely result in a lot of awkward white space in a grid format. In a three-column grid, one comment will stretch the height of the row while anonymous donations will have nothing to fill that space.

This needs further discussion before defining the default behavior.

@mathetos What do you think about displaying anonymous donations by default and concerns over its effect on presentation?

@mathetos

This comment has been minimized.

Copy link
Member Author

commented Nov 15, 2018

We've had feedback already that the Donor Wall presentation is already lackluster. It might be worth a bit of a UI redesign anyway, and that would make this task far easier.

I think the value to ORGS using Donor Wall to show Anonymous donations without names/faces/comments is the primary concern or goal here. I believe we can get that done and a new design that we're proud of.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

Slack Chat Summary

Participants: @kevinwhoffman @DevinWalker @mathetos
Topic: Anonymous behavior
Result: We agree to display anonymous donations by default with an attribute to exclude anonymous donations from the wall if desired. We also agree to not allow the possibility of displaying comments for anonymous donations. Finally the tooltip and description around the anonymous UI needs reviewed for clarity. New acceptance criteria will follow.

@kakshak

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

@kevinwhoffman I need to discuss regarding functionality for this and acceptance criteria regarding that. Let me know when you're available. So, we can discuss this.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

@kakshak See acceptance criteria as we need to clarify the front-end label and tooltip for the anonymous checkbox.

image

@mathetos

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2018

@kevinwhoffman If there's an issue on improving Donor Wall appearance, let's make sure we're not using !important everywhere in the donor wall as well:
image

@mathetos

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2018

Most likely it would also be better to sort the donors with comments to be first as well, for symmetry:

image

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Nov 26, 2018

@kevinwhoffmanI updated Acceptance Criteria.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.