Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove apostrophe as a thousand separator for Taiwan New Dollars #3840

Closed
ravinderk opened this issue Nov 14, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@ravinderk
Copy link
Collaborator

commented Nov 14, 2018

@samsmith89 commented on Tue Nov 06 2018

Bug Report

User Story

As a site admin, I want to remove the apostrophe as the thousand separator with Taiwan New Dollar currency so that my donors aren't confused.

Current Behavior

An apostrophe is added to the Taiwan New Dollar.

Expected Behavior

The use of a comma.

Bug Type

  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Set up Taiwan New Dollars as a possible currency
  2. View the currency on the front-end of the form
  3. See that an apostrophe is present

Visuals

screen shot 2018-11-05 at 3 08 21 pm

Related

https://secure.helpscout.net/conversation/700937121/28645

Acceptance Criteria

  • A comma appears instead of an apostrophe as the thousand separator.

Environment

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome
WordPress System Info ### WordPress Environment ###

Home URL: https://give.gsamsmith.com
Site URL: https://give.gsamsmith.com
WP Version: 4.9.8
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 4b8_
Table Prefix Length: 4
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, in-progress, failed, wc-pending, wc-processing, wc-on-hold, wc-completed, wc-cancelled, wc-refunded, wc-failed, refunded, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.gsamsmith.com
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache
PHP Version: 7.0.32
PHP Post Max Size: 64 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
PHP Max Upload Size: 64 MB
cURL Version: 7.61.1, OpenSSL/1.0.2p
SUHOSIN Installed: –
MySQL Version: 5.6.41
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.3.0
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation ReceiptNew Offline DonationOffline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access✔Daily Email Report✔Weekly Email Report✔Monthly Email ReportRenewal Receipt EmailSubscription Cancelled EmailSubscription Completed Email✔Subscription Reminder Email✔Subscriptions Email Access
Upgraded From: 2.2.4
Test Mode: Enabled
Currency Code: GBP
Currency Position: Before
Decimal Separator: .
Thousands Separator: '
Success Page: https://give.gsamsmith.com/donation-confirmation/
Failure Page: https://give.gsamsmith.com/donation-failed/
Donation History Page: https://give.gsamsmith.com/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Stripe - Credit Card, Stripe + Plaid, Test Donation, GoCardless
Default Payment Gateway: Stripe + Plaid
PayPal IPN Verification: Disabled
PayPal IPN Notifications: IPN received for #559 ( 3BN08235P5725643D ) on 10/15/2018 at 15:34. Status N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Authorize.net Gateway: Unlicensed – by WordImpress – 1.4.3
Give - Currency Switcher: Unlicensed – by GiveWP – 1.3.0
Give - Email Reports: Unlicensed – by WordImpress – 1.1.2
Give - Fee Recovery: Unlicensed – by GiveWP – 1.7.2
Give - Form Field Manager: Unlicensed – by GiveWP – 1.4.0
Give - GoCardless Gateway: ✔ Licensed – by WordImpress – 1.2.1
Give - Google Analytics Donation Tracking: Unlicensed – by GiveWP – 1.2.1
Give - iATS Payment Solutions: ✔ Licensed – by WordImpress – 1.0.3
Give - Manual Donations: ✔ Licensed – by WordImpress – 1.4.1
Give - PayPal Pro Gateway: Unlicensed – by GiveWP – 1.2.0
Give - PDF Receipts: Unlicensed – by WordImpress – 2.3
Give - Recurring Donations: ✔ Licensed – by WordImpress – 1.8.1
Give - Stripe Gateway: Unlicensed – by GiveWP – 2.1.2
Give - Tributes: ✔ Licensed – by WordImpress – 1.5.0
Give - Zapier: ✔ Licensed – by WordImpress – 1.2.1
WP Rollback: Unlicensed – by WordImpress – 1.5.1

Other Active Plugins

All-in-One WP Migration: by ServMask – 6.78
Contact Form 7: by Takayuki Miyoshi – 5.0.4
Email Cop: by Ashfame – 0.1.1
Give - Sofort Payment Gateway: by WordImpress, CoachBirgit – 1.0
My Custom Functions: by Space X-Chimp – 4.31
Query Monitor: by John Blackbourn & contributors – 3.1.1
Transients Manager: by Pippin Williamson – 1.7.5
WooCommerce: by Automattic – 3.5.0

Inactive Plugins

Akismet Anti-Spam: by Automattic – 4.0.8
Debug Bar: by wordpressdotorg – 0.9
Give - 2Checkout Gateway: by WordImpress – 1.1.2
Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0
Give - AWeber: by WordImpress – 1.0.3
Give - Braintree Gateway: by WordImpress – 1.2.2
Give - CCAvenue Gateway: by WordImpress – 1.0.2
Give - Constant Contact: by WordImpress – 1.2.1
Give - ConvertKit: by WordImpress – 1.0.2
Give - CSV Toolbox: by WordImpress – 1.0
Give - Dwolla Gateway: by WordImpress – 1.1.2
Give - Gift Aid: by WordImpress – 1.1.6
Give - MailChimp: by WordImpress – 1.4.1
Give - Mollie Gateway: by WordImpress – 1.1.1
Give - PayFast Payment Gateway: by WordImpress – 1.0.2
Give - Paymill Gateway: by WordImpress – 1.0.2
Give - Paytm Gateway: by WordImpress – 1.0
Give - PayUmoney: by GiveWP – 1.0.2
Give - Per Form Gateways: by WordImpress – 1.0.1
Give - Razorpay: by WordImpress – 1.2.0
Gutenberg: by Gutenberg Team – 3.8.0
Head and Footer Scripts Inserter: by Space X-Chimp – 4.33
Invisible reCaptcha: by Mihai Chelaru – 1.2.1

Active MU Plugins

Endurance PHP Edge: by Mike Hansen – 0.2
SSO: by Garth Mortensen, Mike Hansen – 0.3

Theme

Name: Twenty Seventeen
Version: 1.7
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.