Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register table on plugin activation instead of check when DB class creates #3854

Closed
ravinderk opened this issue Nov 20, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@ravinderk
Copy link
Collaborator

commented Nov 20, 2018

Description

Currently, every DB class calls register_table function when creating object ob that class which first do a SQL query to compare DB version, if we have the old version to DB then new table will install.

ref: https://github.com/impress-org/give/blob/release/2.3.1/includes/class-give-db-comments.php#L43

We can reduce up to 10 query on every page load by moving table register functionality to plugin activate: https://github.com/impress-org/give/find/release%2F2.3.1

Acceptance Criteria

  • Make table register process to the plugin activation
  • Get all DB version at once *_db_version for table version comparison (no need)
  • Table must install on single site on activation.
  • Table must install on subsite on activation of multisite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.