Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: improve focus behavior in multi-level forms #3889
As a donor, I want to be able to change the focus of a field by clicking on it only once so that I can enter information.
Currently, if the amount field is selected on a multilevel form with custom amounts enabled, and then you click to focus on the Prénom field, it shifts focus from the amount field to the first level:
One click should cause the focus to shift to the Name field.
Steps to Reproduce
WordPress System Info### WordPress Environment ###
Home URL: https://livegive.wpsteward.com
Hosting Provider: DBH: localhost, SRV: livegive.wpsteward.com
Give Version: 2.3.0
Active Give Add-ons
Give - Authorize.net Gateway: ✔ Autorisé – par WordImpress – 1.4.3
Other Active Plugins
Ben's Helper Functions: par BenUNC –
Akismet Anti-Spam: par Automattic – 4.1
Active MU Plugins
api-hacks.php: par –
Name: Twenty Seventeen
Slack Call Summary
Participants: @kakshak @ravinderk
@kevinwhoffman I've check that and I think it's a default behaviour of Give plugin. So, user will know in which level currently he/she is. If user wants to edit that focus then I've provided the solution that can be implement for the user speicific website.
Please let me know your thoughts on this.
Thanks for the clarification @kakshak. In my tests the other day I wasn't seeing this default behavior... which is likely a mistake on my part, I see it now regardless of language.
I still think this needs some attention from a user experience perspective.
I'd expect the amount to stay colored even once the user has moused into another field. Perhaps style based on
This would also alleviate this user's problem, which is that it takes two clicks to get into the field to enter the First Name if you come directly from the amount field.
I will set expectations accordingly with the user, either way.
@Benunc I agree that it should only take one click to jump from the amount field to the name field. The selected button style should also be maintained regardless of focus.
Related to this, users have asked for a long time to allow the custom amount to be the default option. The only way we can do that currently is with a jQuery snippet that focuses on the amount field. When that happens, we should ensure that the Custom Amount button maintains focus.