Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update russian ruble currency formatting #3893

Closed
mehul0810 opened this issue Dec 7, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@mehul0810
Copy link
Contributor

commented Dec 7, 2018

Bug Report

User Story

As a user, I want to accept donations using Russian Rubles so that I can receive the correct donation amount.

Current Behavior

Currently, While using Stripe I can see that the currency formatting implemented to Russian rubles is wrong.

Expected Behavior

Russian Rubles currency formatting should be correct.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Install & Activate Give & Stripe
  2. Add donation amount like 50000
  3. Try donating via Stripe Checkout
  4. Notice incorrect formatting for currency Russian Rubles in the Stripe Checkout popup.

Visuals

gif

Possible Solution

Change the thousands separator to , and decimals separator to . for Russian Rubles currency.

Related

Other Sources to check Currency Formatting for Russian Rubles

Acceptance Criteria

  • Change the thousands separator to , and decimals separator to . for Russian Rubles currency.
  • Follow Steps to Reproduce to test the fix.

@mehul0810 mehul0810 self-assigned this Dec 7, 2018

ravinderk added a commit that referenced this issue Dec 10, 2018

Merge pull request #3894 from impress-org/issue/3893
fix: update russian ruble currency formatting #3893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.