Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update email tag descriptions for name and company #3943

Closed
mathetos opened this issue Jan 16, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@mathetos
Copy link
Member

commented Jan 16, 2019

Bug Report

User Story

As a Give user I want to know what to expect when I use certain email tags in my email notifications.

Current Behavior

The {name} email tag currently is described as:

The donor's first name

See here:
image

But in reality, it displays different things under different circumstances:

  • If there is no last name, it displays only the first name
  • If there is a prefix and last name, it display those and NOT the first name.

Expected Behavior

I think we should simply update the description of this tag to the following:

Displays the donor's name for salutation purposes; either just the first name, or prefix and last name if provided.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X. -- most likely when we introduced the prefixes this got changed but not he tag description.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. View the tag description
  2. Test the output by having different donations with just a first name, just a prefix and first name, and prefix/first/last all present and preview the email with the Preview Email feature.

Acceptance Criteria

  • The email tag description is updated in every place where it exists.

@kevinwhoffman kevinwhoffman changed the title fix: {name} email tag description is inaccurate fix: update email tag descriptions for name and company Jan 18, 2019

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

@nishitlangaliya There are two email tags and descriptions that need to be clarified and made consistent with the other descriptions. Please update the following descriptions for {name} and {company}.

{name} - The donor's name for salutation purposes—either first name only or prefix and last name if provided.

{company} - The donor's company name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.