Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect title placement within give form widget #3947

Closed
DevinWalker opened this issue Jan 17, 2019 · 6 comments

Comments

Projects
None yet
5 participants
@DevinWalker
Copy link
Member

commented Jan 17, 2019

Bug Report

Reported here: https://wordpress.org/support/topic/update-caused-widget-display-issues/

User Story

As a admin, I do not want the form title to display when I add a Give Form Widget in the sidebar so that donors don't see duplicate titles or content displayed above the title.

Expected Behavior

The form title always appears at the top of the widget regardless of configuration.

Bug Type

  • This bug describes functionality that once worked as expected in version 2.3.1.

Steps to Reproduce

  1. Create a donation form with dummy content like lorem ipsum
  2. Add the donation form to the sidebar in modal view with content displayed above the form
  3. Visit the sidebar on the frontend and open the modal and close it

Visuals

2019-01-17_14-27-56

Possible Solution

  1. Option 1: Display the title only when
  2. Option 2: Never display the title in the donation form widget like previous versions.

Related

#3881

@marutim

This comment has been minimized.

Copy link

commented Jan 22, 2019

@DevinWalker I would also like to add that I can replicate this issue with the give_form shortcode and Give form block.

The form title appears irrespective of whether it is set to show_title="False" in shortcode or title being disabled in the block settings.

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

I've taken care of the shortcode attributes and Gutenberg blocks @marutim in #3991

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2019

@DevinWalker Closing this issue

@ravinderk ravinderk closed this Feb 7, 2019

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2019

@mehul0810 @DevinWalker reopening this issue because it needs to be tested with past issue: #3881

In both issue with edited same condition
past issue:
ccd724d

current issue:
https://github.com/impress-org/give/pull/3991/files#diff-143c1ae2e57a1cf5852d709be4b5aa85R111

@ravinderk ravinderk reopened this Feb 7, 2019

@mehul0810

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Slack Call Summary

Participants: @mehul0810 @ravinderk
Topic: Discussion about this issue
Result: This issue is not fixed yet or maybe not worked upon. However, #3881 is working fine as per my testing over a call with Ravinder. While testing #3881, I noticed an issue with currency switcher dropdown in the modal popup of form grid for which I'll create an issue

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

I've confirmed this issue is resolved.

@DevinWalker DevinWalker closed this Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.