Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop loading donor notes when create Give_donor object #3994

Closed
ravinderk opened this issue Feb 8, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@ravinderk
Copy link
Collaborator

commented Feb 8, 2019

Performance Improvement Request

User Story

As a site owner, I want my donation form to load faster.

Current Behavior

when donor logged in then on the donation form page, I can see one extra query which we can neglect

Expected Behavior

Run queries only which are useful

Visuals

image

Possible Solution

Do not load notes when creating Give_Donor object. Move them to on-demand functionality. I think we can use the class __get function to set and fetch donor notes dynamically instead of object creation

Acceptance Criteria

  • Give_Donor object has empty notes when creating an object
  • Return notes when developer access notes property of Give_Donor class

DevinWalker added a commit that referenced this issue Feb 26, 2019

Merge pull request #4019 from impress-org/issue/3994
fix: stop loading donor notes when create Give_donor object #3994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.