Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent warning in System Info host detection #4041

Closed
kevinwhoffman opened this issue Mar 13, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@kevinwhoffman
Copy link
Member

commented Mar 13, 2019

Bug Report

User Story

As a user, I want to view and copy my System Info without errors so that I can provide accurate information to support.

Current Behavior

Currently the condition for Bluehost detection is causing a warning if a host is not detected before the switch statement gets to Bluehost.

Expected Behavior

The switch statement should continue processing through to the default case.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. View system info screen in Give 2.4.2 in a local dev environment.

Visuals

image

Possible Solution

Correct the use of preg_match().

Related

#3356

Acceptance Criteria

  • There are no errors when System Info is viewed in a local environment.
  • There are no errors when System Info is viewed in a production environment.

@kevinwhoffman kevinwhoffman self-assigned this Mar 13, 2019

DevinWalker added a commit that referenced this issue Mar 13, 2019

Merge pull request #4042 from impress-org/issue/4041
fix: prevent warning in System Info host detection #4041
@DevinWalker

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Resolved in PR #4042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.