Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure when "login" option is selected it does not appear optional on the donation form #4045

Closed
DevinWalker opened this issue Mar 13, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@DevinWalker
Copy link
Member

commented Mar 13, 2019

Bug Report

If Login is enabled for a form, it appears as "optional" but is actually required. You cannot submit a donation without logging in.

User Story

As a donor, I want to ensure that when a login is required it does not appear optional so that I'm not confused when attempting to donate.

Bug Type

  • This bug describes functionality that never worked as expected.

Steps to Reproduce

  1. Create a new donation form
  2. Select the "login" option within the Form Display
  3. View the form in incognito mode

Visuals

2019-03-13_13-43-36

Possible Solution

Check if the login option is set before outputting the "Optional" text

Related

Acceptance Criteria

  • I can select the "Login" Display mode and the form won't display the "Optional" incorrectly

@DevinWalker DevinWalker self-assigned this Mar 13, 2019

@DevinWalker DevinWalker changed the title fix: ensure when "login" option is selected it does not appear option on the donation form fix: ensure when "login" option is selected it does not appear optional on the donation form Mar 14, 2019

@DevinWalker DevinWalker referenced this issue Mar 14, 2019

Merged

Issue/4045 #4046

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.