Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make db upgrade background process compatible with multisite #4065

Closed
ravinderk opened this issue Mar 27, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@ravinderk
Copy link
Collaborator

commented Mar 27, 2019

Bug Report

User Story

As an admin, I want to run DB upgrade on multiple site without any issue.

ref: https://secure.helpscout.net/conversation/793091260/35410?folderId=848135

Current Behavior

When running DB upgrade on a subsite of multisite then logic fetches batch from sitemeta instead of subsite options table. On an edge case, it will fail.

Expected Behavior

Run DB upgrade on subsite without any issue.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Create two websites on multisite
  2. Install an older version of Give [network activate].
  3. Run DB upgrade on the first subsite and complete them
  4. Run DB upgrade on second subsite and pause in between.
  5. Install older recurring addon [network activate].
  6. Run DB upgrade on first subsite [now this site only has recurring addon updates]
  7. You will see that that DB upgrade will not achieve any process.

Possible Solution

Update background update logic to get batch from subsite option table instead of sitemeta table.

Acceptance Criteria

  • Logic fetching batch from subsite option table instead of sitemeta table.
  • DB upgrades on subsite without any issue.

@ravinderk ravinderk self-assigned this Mar 27, 2019

ravinderk added a commit that referenced this issue Mar 27, 2019

DevinWalker added a commit that referenced this issue Apr 2, 2019

Merge pull request #4066 from impress-org/issue/4065
fix: make db upgrade background process compatible with multisite #4065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.