Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display donations made in 2019 when the site date format is set to d/m/Y #4088

Closed
Benunc opened this issue May 2, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@Benunc
Copy link
Member

commented May 2, 2019

Bug Report

User Story

As a site admin, I want donations to show in the list at Donations > Donations even when the site date format is set to d/m/Y so that all my donations are visible.

Current Behavior

With the date format set at Settings > General to d/m/Y (one of the default options on US WordPress installs) any donation that is made in 2019 does not display in any of the lists.

Expected Behavior

I expect donations to show in the list.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Import the sample data CSV into a fresh install.
  2. Change the date format to d/m/Y at Settings > General
  3. Navigate to the donation list (everything displays as expected)
  4. In a new tab/window, create a new donation from the front end
  5. Refresh the donation list. (the newest donation does not display)
  6. Change the date format to j F, Y
  7. Refresh the donation list (the newest donation appears)

Related

facebook messenger for GiveWP account message from Cherie Brown

Acceptance Criteria

  • The donation list displays no matter what the date format is set to

Environment

WordPress System Info ### WordPress Environment ###

Home URL: http://samdestroysthings.local
Site URL: http://samdestroysthings.local
WP Version: 5.1.1
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: samdestroysthings.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.10.1
PHP Version: 7.1.4
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.4.5
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Database Tables: ✔ wp_give_donors - 1.0✔ wp_give_donormeta - 1.0✔ wp_give_comments - 1.0✔ wp_give_commentmeta - 1.0✔ wp_give_sessions - 1.0✔ wp_give_logs - 1.0✔ wp_give_logmeta - 1.0✔ wp_give_formmeta - 1.0✔ wp_give_sequential_ordering - 1.0✔ wp_give_donationmeta - 1.0
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://samdestroysthings.local/donation-confirmation/
Failure Page: http://samdestroysthings.local/donation-failed/
Donation History Page: http://samdestroysthings.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Form Field Manager: Unlicensed – by GiveWP – 1.4.3

Other Active Plugins

Inactive Plugins

Theme

Name: Twenty Nineteen
Version: 1.3
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

@Benunc Benunc added the urgent label May 2, 2019

@ravinderk ravinderk self-assigned this May 3, 2019

DevinWalker added a commit that referenced this issue May 3, 2019

Merge pull request #4089 from impress-org/issue/4088
fix: display donations made in 2019 when the site date format is set to d/m/Y #4088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.