Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent memory exhausted issue when do query for all donations #4104

Closed
ravinderk opened this issue May 10, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@ravinderk
Copy link
Collaborator

commented May 10, 2019

Bug Report

User Story

As an admin, I do not want any functionality to break because of memory exhausted. In practical case when using Give_Payments_Query calculate total donations or number set to -1 then we will face this issue if the number of donation is > 6000 and memory_limit set to 256M

ref: https://core.trac.wordpress.org/ticket/14254

Current Behavior

We will get a fatal error if query all donations at once because long query generates to update the meta cache.

Expected Behavior

Functionality must not break due to the number of donation in the query.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. create a site with > 6000 donation
  2. Set memory limit to 256M
  3. Export donations

Possible Solution

Do not update donation meta cache when query for -1 number of donations.

Acceptance Criteria

  • We are able to export donations on large database without any issue.

@ravinderk ravinderk added this to the May 2019 milestone May 10, 2019

@ravinderk ravinderk self-assigned this May 10, 2019

ravinderk added a commit that referenced this issue May 14, 2019

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2019

@ravinderk ravinderk closed this May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.