Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: improve logic for donor and user profile disconnection #4113
Sigh, user stories...
This does not impact functionality.
However there is a logic bug in
When disconnecting a donor in the admin panel
How I realized this is that I was wondering why in
Looking at the database these meta keys are never present anywhere for a user. That is because of the incorrect true/false check in give_disconnect_donor_user_id().
Honestly, I can’t even figure out why you wanted to set those 3 metas in the first place. I don’t see any other functions that would use them, so they seem redundant??
Steps to Reproduce
Though I didn't test it, I'd assume change the if statement to
or maybe rethink what those _give_disconnected_user_id, etc were supposed to be used for?
Give version 2.4.7