Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not check url param when validate setting page tab and section #4114

Closed
ravinderk opened this issue May 21, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@ravinderk
Copy link
Collaborator

commented May 21, 2019

Bug Report

User Story

As a developer, I want the true result when setting page match with tab and section.

ref:

if ( ! empty( $tab ) && isset( $_GET['tab'] ) ) {

Current Behavior

Currently, we are checking for isset( $_GET['tab'] ) and isset( $_GET['section'] ) url param which skip comparision even if we are comparing section or tab.

Expected Behavior

Compare for tab and section both if present.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Register a notice.
  2. Show it on a specific section with Give_Admin_Settings::is_setting_page

Possible Solution

The function will return the correct output if we will remove isset from if conditions.

Acceptance Criteria

  • Function returns true only if tab and section match.

@ravinderk ravinderk added this to the May 2019 milestone May 21, 2019

@ravinderk ravinderk self-assigned this May 21, 2019

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@ravinderk ravinderk closed this May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.