Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Hint.css for our Tooltips instead of QTips2 #619
While QTip is a good library, it's heavily JS based. When tiny JS errors that we can't control happen on the form page the QTips often just break.
Hint.css is pure CSS based. Of course there's potential that themes might mess with it in one way or another, but their repo is very active and they put a lot of attention on making their styles very strict in to avoid conflicts like that. Plus it would make styling them very easy.
@DevinWalker would love your input.
I'm more in the mind set to not switch from qtip2 for a few reasons:
We're reconsidering this primarily because we've uncovered a couple sites in which the qtip library broke the JS on a page for a client, causing issues with the functionality of the page.
Using a CSS method would necessarily open up potential theme conflicts, but hint.css is built in a way to do its best to avoid that problem overall.
Additionally, hint.css relies on aria-label to populate the hints which is a good practice for #a11y improvements. To address Devin's concerns above, here's why:
The BIGGEST reason though is if CSS breaks, it doesn't break the page like Qtip currently does. It'll trim up our JS file a bit, including the give-ajax file. I think it's a win.
changed the title from
Consider using Hint.css for our Tooltips instead of QTips2
Hint.css for our Tooltips instead of QTips2
Aug 16, 2016
Here's another example of a Give form getting ruined because of a plugin conflict with qTip:
Would love to see this bumped up to 1.7 if possible.
I dug into this a bit today, here's an example of what it would take to make this happen.
Here's the current markup of the "First Name" input hint
With Hint.css Instead
Items to Consider
Here's a couple other items I found useful:
@DevinWalker What do you think about enqueueing hint.css separately from give.min.css? I think it would be useful for those users who want to apply their own hint.css styles to be able to just unequeue ours and enqueue their own. The additional HTTP request isn't as severe an issue as it used to be, particularly with HTTP/2 already rolling out.
I'm fine with that. I want to load scripts conditionally as well.…
On Mon, Dec 26, 2016 at 11:45 AM, Matt Cromwell ***@***.***> wrote: @DevinWalker <https://github.com/DevinWalker> What do you think about enqueueing hint.css separately from give.min.css? I think it would be useful for those users who want to apply their own hint.css styles to be able to just unequeue ours and enqueue their own. The additional HTTP request isn't as severe an issue as it used to be, particularly with HTTP/2 already rolling out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABf7M43Z9IC-UcKPr8GlYtoh5O9xzBgBks5rMBk9gaJpZM4IiimF> .
-- Devin Walker Founder & Lead Developer P: 858-449-6460 <8584496460> W: https://wordimpress.com 433 G Street #201 San Diego, CA 92101 <https://goo.gl/maps/BePgp> <https://www.facebook.com/wordimpressive> <https://twitter.com/wordimpress> <https://plus.google.com/u/0/b/117062083910623146392/+Wordimpress/about> <http://wordimpress.com/>