New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-donation / ecommerce terminology in actions and filters #896

Closed
DevinWalker opened this Issue Aug 15, 2016 · 12 comments

Comments

Projects
None yet
5 participants
@DevinWalker
Member

DevinWalker commented Aug 15, 2016

There are many actions and filters throughout the plugin which use ecommmerce terminology such as give_purchase_form, give_purchase_form_wrap_bottom, give_purchase_form_before_submit, etc.

We should deprecate them and replace with donation based terminology. give_purchase_form --> give_donation_form, give_purchase_form_wrap_bottom -> give_donation_form_wrap_bottom

Task list:

  • Rename directories
  • Rename variables
  • Rename hooks (actions + filters)
  • Rename classes
  • Rename db tables w/ upgrade routine

All items above with backwards compatibility

@DevinWalker DevinWalker added this to the 1.9 milestone Aug 15, 2016

@DevinWalker DevinWalker added enhancement and removed enhancement labels Aug 15, 2016

@ramiy

This comment has been minimized.

Show comment
Hide comment
@ramiy

ramiy Aug 17, 2016

Contributor

Agree, we need to consolidate Give terminology.

Here is another example for three different names for the same thing:

ternimology

I think we need to fix the front-end first, and only then the classes/functions/hooks names.

Contributor

ramiy commented Aug 17, 2016

Agree, we need to consolidate Give terminology.

Here is another example for three different names for the same thing:

ternimology

I think we need to fix the front-end first, and only then the classes/functions/hooks names.

@ramiy

This comment has been minimized.

Show comment
Hide comment
@ramiy

ramiy Aug 17, 2016

Contributor

As for the purchase, it is deeply embedded in the code. We have function names using this word, class properties and methods, and maybe even options (not sure about the last one - I need to check that).

It's a backwards-compatibility nightmare.

Contributor

ramiy commented Aug 17, 2016

As for the purchase, it is deeply embedded in the code. We have function names using this word, class properties and methods, and maybe even options (not sure about the last one - I need to check that).

It's a backwards-compatibility nightmare.

@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Aug 17, 2016

Member

Yeah I know, that's why I've been resisting it. This is an ongoing gradual task.

Member

DevinWalker commented Aug 17, 2016

Yeah I know, that's why I've been resisting it. This is an ongoing gradual task.

@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Aug 17, 2016

Member

Link for reference to _deprecated_hook function new to WP 4.6

Changeset: https://core.trac.wordpress.org/changeset/37861

Ticket: https://core.trac.wordpress.org/ticket/10441

Member

DevinWalker commented Aug 17, 2016

Link for reference to _deprecated_hook function new to WP 4.6

Changeset: https://core.trac.wordpress.org/changeset/37861

Ticket: https://core.trac.wordpress.org/ticket/10441

@DevinWalker DevinWalker added the ongoing label Aug 17, 2016

@DevinWalker DevinWalker removed this from the 1.9 milestone Aug 17, 2016

@ramiy

This comment has been minimized.

Show comment
Hide comment
@ramiy

ramiy Aug 17, 2016

Contributor

@DevinWalker Translations strings updates are simpler and faster. I can do it in 1.7 , I just need know which word is preferred?

Contributor

ramiy commented Aug 17, 2016

@DevinWalker Translations strings updates are simpler and faster. I can do it in 1.7 , I just need know which word is preferred?

@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Aug 17, 2016

Member

"Transactions" -> "Donations"

"Payment" -> "Donation"

@mathetos thoughts?

Member

DevinWalker commented Aug 17, 2016

"Transactions" -> "Donations"

"Payment" -> "Donation"

@mathetos thoughts?

DevinWalker added a commit that referenced this issue Aug 17, 2016

DevinWalker added a commit that referenced this issue Aug 22, 2016

DevinWalker added a commit that referenced this issue Aug 22, 2016

Merge branch 'release/1.7' into issue/176
* release/1.7: (765 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...

# Conflicts:
#	assets/css/give-admin.min.css
#	assets/js/admin/admin-forms.js
#	assets/js/admin/admin-forms.min.js
#	assets/js/frontend/give.js
#	assets/js/frontend/give.min.js
#	assets/sourcemaps/give-admin.css.map
#	assets/sourcemaps/give.css.map
#	includes/admin/forms/metabox.php
#	includes/admin/payments/actions.php
#	includes/admin/payments/view-order-details.php
#	includes/admin/upgrades/upgrade-functions.php
#	includes/admin/upgrades/upgrades.php
#	includes/class-give-customer.php
#	includes/class-give-db.php
#	includes/class-give-donate-form.php
#	includes/class-give-stats.php
#	includes/emails/class-give-email-tags.php
#	includes/forms/functions.php
#	includes/forms/template.php
#	includes/payments/actions.php
#	includes/payments/class-give-payment.php
#	includes/payments/class-payments-query.php
#	includes/payments/functions.php
#	includes/price-functions.php
#	includes/scripts.php
#	includes/user-functions.php
#	readme.txt
#	templates/give.min.css
#	templates/shortcode-receipt.php
#	tests/framework/helpers/class-helper-form.php
#	tests/framework/helpers/class-helper-payment.php
#	tests/unit-tests/tests-payment-class.php

DevinWalker added a commit that referenced this issue Aug 22, 2016

Merge branch 'release/1.7' into issue/357
* release/1.7: (929 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...

DevinWalker added a commit that referenced this issue Aug 22, 2016

Merge branch 'release/1.7' into issue/370
* release/1.7: (66 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...

# Conflicts:
#	includes/forms/template.php

DevinWalker added a commit that referenced this issue Aug 22, 2016

Merge branch 'release/1.7' into issue/668
* release/1.7: (316 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...

@ravinderk ravinderk referenced this issue Aug 24, 2016

Merged

Issues/896 #950

@DevinWalker DevinWalker changed the title from Fix ecommerce terminology in actions and filters to Fix non-donation / ecommerce terminology in actions and filters Aug 26, 2016

DevinWalker added a commit that referenced this issue Aug 26, 2016

DevinWalker added a commit that referenced this issue Aug 29, 2016

Merge branch 'release/1.7' into issue/619
* release/1.7: (177 commits)
  Added change log for #964
  Make exception message translatable
  Update give_do_automatic_upgrades function
  Move upgades to 1.7
  Update function version from 1.6 to 1.7
  add missing `echo` after 9a2f35d
  Set gulp textdomain task autocorretion to true
  Update more action names #957
  Update actions to use newly termed ones rather than now deprecated ones #957
  Version bump for release/1.7 branch
  Change log added for #687
  Readme logs added for #896 and #773
  replace `edd` text-domain with `give`
  replace esc_attr_e() with esc_attr()
  add misisng text-domain
  gulp task
  Update doc block in formatting.php
  Refresh current month transient when payment update
  Add function to get stat transient key
  Update description in Give Settings Screen
  ...
@ramiy

This comment has been minimized.

Show comment
Hide comment
@ramiy

ramiy Aug 30, 2016

Contributor

@DevinWalker @mathetos

One more terminology suggestion: Donators > Donors

Ref: https://github.com/WordImpress/Give/blob/master/includes/class-give-gravatars.php

Do you agree?

Contributor

ramiy commented Aug 30, 2016

@DevinWalker @mathetos

One more terminology suggestion: Donators > Donors

Ref: https://github.com/WordImpress/Give/blob/master/includes/class-give-gravatars.php

Do you agree?

DevinWalker added a commit that referenced this issue Aug 30, 2016

Better filter naming give_recount_customer_donation_statuses -> give_…
…recount_donors_donation_statuses and give_customer_recount_should_process_donation -> give_donor_recount_should_process_donation

#957 #896
@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Aug 30, 2016

Member

@ramiy yes definitely, that class isn't being used yet though :(

Member

DevinWalker commented Aug 30, 2016

@ramiy yes definitely, that class isn't being used yet though :(

DevinWalker added a commit that referenced this issue May 31, 2017

DevinWalker added a commit that referenced this issue May 31, 2017

DevinWalker added a commit that referenced this issue May 31, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

Deprecated give_get_total_sales() for give_get_total_donations() #896
Renamed a bunch of $customer vars to $donor

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 1, 2017

DevinWalker added a commit that referenced this issue Jun 2, 2017

DevinWalker added a commit that referenced this issue Jun 2, 2017

DevinWalker added a commit that referenced this issue Jun 2, 2017

DevinWalker added a commit that referenced this issue Jun 2, 2017

@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Mar 20, 2018

Member

This bulk of this task is done. As we continue to refactor we can take care of the remaining hooks and variables.

Member

DevinWalker commented Mar 20, 2018

This bulk of this task is done. As we continue to refactor we can take care of the remaining hooks and variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment