New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve block styling and usability #3887 #3888

Merged
merged 28 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@kevinwhoffman
Member

kevinwhoffman commented Dec 4, 2018

Description

Resolves #3887 by fixing styling conflicts and improving block usability.

Acceptance criteria have been satisfied and additional work has been done to make blocks compatible with WP 5.0.

@kevinwhoffman

This comment has been minimized.

Member

kevinwhoffman commented Dec 5, 2018

@ravinderk Please pick up where I left off on this branch and resolve the remaining acceptance criteria in #3887.

Here's a screencast demonstrating the current issues with the Form block's content setting: https://www.useloom.com/share/5840e56b18684282ad02879ffba0f35a

@ravinderk

This comment has been minimized.

Collaborator

ravinderk commented Dec 5, 2018

@kevinwhoffman Can you explain The Form block does not spin upon initialization. from Acceptance Criteria.

Rest I fixed. please review it when you have time. I will continue testing tomorrow.

@ravinderk

This comment has been minimized.

Collaborator

ravinderk commented Dec 6, 2018

@kevinwhoffman I fixed most of Gutenberg related issue, please review this PR and fix if any styling issue still left.

ravinderk added some commits Dec 12, 2018

style: remove todo comment
we are handling blank template with rest response

@ravinderk ravinderk changed the base branch from release/2.3.1 to master Dec 12, 2018

ravinderk added some commits Dec 12, 2018

@ravinderk

This comment has been minimized.

Collaborator

ravinderk commented Dec 12, 2018

ravinderk and others added some commits Dec 12, 2018

Merge branch 'master' into issue/3887
# Conflicts:
#	blocks/donation-form-grid/edit/block.js
@kevinwhoffman

This comment has been minimized.

Member

kevinwhoffman commented Dec 12, 2018

@ravinderk I'm seeing two different blank slate experiences when the form grid block is inserted without forms:

  1. I would like to see this blank slate whenever there are no forms.

image

  1. However I often see this version instead with a giant logo and no button. Try inserting the form grid block, then deleting it, and inserting it again to trigger this version.

image

Can you make sure the first version is always used when there are no forms?

@ravinderk

This comment has been minimized.

Collaborator

ravinderk commented Dec 12, 2018

@kevinwhoffman First blank template comes from: blocks/components/no-form/index.js second comes from Give_Donor_Wall_Block::blank_slate. If we want the same blank slate then we have to create a custom component which will extend ServerSideRender.

@kevinwhoffman

This comment has been minimized.

Member

kevinwhoffman commented Dec 12, 2018

@ravinderk Thanks I'm sorting it out now and will merge once the two versions are styled the same.

@kevinwhoffman kevinwhoffman merged commit 4ef638f into master Dec 12, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@kevinwhoffman kevinwhoffman deleted the issue/3887 branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment