Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give Reports section no thousands separator #2053

Closed
2 tasks
raftaar1191 opened this issue Sep 7, 2017 · 2 comments
Closed
2 tasks

Give Reports section no thousands separator #2053

raftaar1191 opened this issue Sep 7, 2017 · 2 comments
Milestone
1.8.14

Comments

@raftaar1191
Copy link
Contributor

raftaar1191 commented Sep 7, 2017 •
edited

Issue Overview

In the give report section, there is no Thousands Separator user to diff between the amount
See the video for more clarification
http://screencast-o-matic.com/watch/cbQi30IQK4

Expected Behavior

It should show the Thousands Separator sign that is being set from the give setting> currency tab

Current Behavior

NoThousands Separator sign is used

Steps to Reproduce (for bugs)

1.Click on the Report tab if the give inside the income tab on the right side you can see that there is not NoThousands Separator sign is used

Related Issues and/or PRs

#1981
#1982

Todos

  • Tests
  • Documentation
@DevinWalker DevinWalker added this to the 1.8.14 milestone Sep 7, 2017
@DevinWalker DevinWalker added bug and removed bug labels Sep 7, 2017
@Sidsector9 Sidsector9 mentioned this issue Sep 13, 2017
Merged
3 tasks
@DevinWalker
Copy link
Member

Thanks @Sidsector9 !

@Sidsector9
Copy link
Contributor

You're welcome @DevinWalker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.14
Development

No branches or pull requests
3 participants
@DevinWalker @Sidsector9 @raftaar1191